From: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@fb.com>, David Howells <dhowells@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 6/8] nilfs2: set up s_bdi like the generic mount_bdev code
Date: Sun, 04 Jan 2015 17:18:38 +0900 (JST) [thread overview]
Message-ID: <20150104.171838.243342727322803372.konishi.ryusuke@lab.ntt.co.jp> (raw)
In-Reply-To: <1419929859-24427-7-git-send-email-hch@lst.de>
On Tue, 30 Dec 2014 09:57:37 +0100, Christoph Hellwig <hch@lst.de> wrote:
> mapping->backing_dev_info will go away, so don't rely on it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good for me.
Acked-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
> ---
> fs/nilfs2/super.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c
> index 2e5b3ec..3d4bbac 100644
> --- a/fs/nilfs2/super.c
> +++ b/fs/nilfs2/super.c
> @@ -1057,7 +1057,6 @@ nilfs_fill_super(struct super_block *sb, void *data, int silent)
> {
> struct the_nilfs *nilfs;
> struct nilfs_root *fsroot;
> - struct backing_dev_info *bdi;
> __u64 cno;
> int err;
>
> @@ -1077,8 +1076,7 @@ nilfs_fill_super(struct super_block *sb, void *data, int silent)
> sb->s_time_gran = 1;
> sb->s_max_links = NILFS_LINK_MAX;
>
> - bdi = sb->s_bdev->bd_inode->i_mapping->backing_dev_info;
> - sb->s_bdi = bdi ? : &default_backing_dev_info;
> + sb->s_bdi = &bdev_get_queue(sb->s_bdev)->backing_dev_info;
>
> err = load_nilfs(nilfs, sb);
> if (err)
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-01-04 8:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 8:57 backing_dev_info cleanups Christoph Hellwig
2014-12-30 8:57 ` [PATCH 1/8] fs: deduplicate noop_backing_dev_info Christoph Hellwig
2014-12-30 8:57 ` [PATCH 2/8] fs: kill BDI_CAP_SWAP_BACKED Christoph Hellwig
2014-12-30 8:57 ` [PATCH 3/8] fs: introduce f_op->mmap_capabilities for nommu mmap support Christoph Hellwig
2014-12-30 8:57 ` [PATCH 4/8] block_dev: only write bdev inode on close Christoph Hellwig
2014-12-30 8:57 ` [PATCH 5/8] block_dev: get bdev inode bdi directly from the block device Christoph Hellwig
2014-12-30 8:57 ` [PATCH 6/8] nilfs2: set up s_bdi like the generic mount_bdev code Christoph Hellwig
2015-01-04 8:18 ` Ryusuke Konishi [this message]
2014-12-30 8:57 ` [PATCH 7/8] fs: export inode_to_bdi and use it in favor of mapping->backing_dev_info Christoph Hellwig
2014-12-30 8:57 ` [PATCH 8/8] fs: remove mapping->backing_dev_info Christoph Hellwig
2015-01-04 8:28 ` Ryusuke Konishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150104.171838.243342727322803372.konishi.ryusuke@lab.ntt.co.jp \
--to=konishi.ryusuke@lab.ntt.co.jp \
--cc=axboe@fb.com \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox