From: Andi Kleen <andi@firstfloor.org>
To: Andreas Mohr <andi@lisas.de>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Andi Kleen <andi@firstfloor.org>,
linux-mm@kvack.org, Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] kstrdup optimization
Date: Tue, 30 Dec 2014 22:29:16 +0100 [thread overview]
Message-ID: <20141230212915.GN2915@two.firstfloor.org> (raw)
In-Reply-To: <20141230083230.GA17639@rhlx01.hs-esslingen.de>
> This symmetry issue probably could be cleanly avoided only
> by having kfree() itself contain such an identifying check, as you suggest
> (thereby slowing down kfree() performance).
It actually shouldn't slow it down. kfree already complains if you free
a non slab page, this could be just in front of the error check.
The bigger concern is that it may hide some programing errors elsewhere
though. So it's probably better to keep it a separate function.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-12-30 21:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 14:48 Andrzej Hajda
2014-12-29 14:48 ` [RFC PATCH 1/4] mm/util: add kstrdup_const Andrzej Hajda
2014-12-29 14:48 ` [RFC PATCH 2/4] kernfs: use kstrdup_const for node name allocation Andrzej Hajda
2014-12-29 14:48 ` [RFC PATCH 3/4] clk: use kstrdup_const for clock name allocations Andrzej Hajda
2014-12-29 14:48 ` [RFC PATCH 4/4] mm/slab: use kstrdup_const for allocating cache names Andrzej Hajda
2014-12-30 6:45 ` [RFC PATCH 0/4] kstrdup optimization Andi Kleen
2014-12-30 7:16 ` Andrzej Hajda
2014-12-30 8:32 ` Andreas Mohr
2014-12-30 21:29 ` Andi Kleen [this message]
2015-01-08 10:54 ` Andrzej Hajda
2014-12-31 13:05 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141230212915.GN2915@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=a.hajda@samsung.com \
--cc=andi@lisas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox