From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ganesh Mahendran <opensource.ganesh@gmail.com>,
ngupta@vflare.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/zsmalloc: add statistics support
Date: Sat, 20 Dec 2014 08:58:52 +0900 [thread overview]
Message-ID: <20141219235852.GB11975@blaptop> (raw)
In-Reply-To: <20141219154548.3aa4cc02b3322f926aa4c1d6@linux-foundation.org>
On Fri, Dec 19, 2014 at 03:45:48PM -0800, Andrew Morton wrote:
> On Sat, 20 Dec 2014 08:39:37 +0900 Minchan Kim <minchan@kernel.org> wrote:
>
> > Then, we should fix debugfs_create_dir can return errno to propagate the error
> > to end user who can know it was failed ENOMEM or EEXIST.
>
> Impractical. Every caller of every debugfs interface will need to be
> changed!
If you don't like changing of all of current caller, maybe, we can define
debugfs_create_dir_error and use it.
struct dentry *debugfs_create_dir_err(const char *name, struct dentry *parent, int *err)
and tweak debugfs_create_dir.
struct dentry *debugfs_create_dir(const char *name, struct dentry *parent, int *err)
{
..
..
if (error) {
*err = error;
dentry = NULL;
}
}
Why not?
>
> It's really irritating and dumb. What we're supposed to do is to
> optionally report the failure, then ignore it. This patch appears to
> be OK in that respect.
At least, we should notify to the user why it was failed so he can fix
the name if it was duplicated. So if you don't want debugfs, at least
I want to warn all of reasons it can fail(at least, duplicated name)
to the user.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-12-19 23:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 12:55 Ganesh Mahendran
2014-12-19 22:32 ` Andrew Morton
2014-12-19 23:39 ` Minchan Kim
2014-12-19 23:45 ` Andrew Morton
2014-12-19 23:58 ` Minchan Kim [this message]
2014-12-20 0:06 ` Andrew Morton
2014-12-20 0:10 ` Minchan Kim
2014-12-20 0:17 ` Andrew Morton
2014-12-20 0:23 ` Minchan Kim
2014-12-20 0:54 ` Minchan Kim
2014-12-20 1:43 ` Ganesh Mahendran
2014-12-20 2:25 ` Minchan Kim
2014-12-23 2:26 ` Ganesh Mahendran
2014-12-23 2:40 ` Minchan Kim
2015-01-12 20:07 ` Seth Jennings
2014-12-20 1:35 ` Ganesh Mahendran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219235852.GB11975@blaptop \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=opensource.ganesh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox