[tj-misc:review-wq-dump 1/15] lib/bitmap.c:574:6: sparse: symbol 'bitmap_print_list' was not declared. Should it be static?

[tj-misc:review-wq-dump 1/15] lib/bitmap.c:574:6: sparse: symbol 'bitmap_print_list' was not declared. Should it be static?

[kbuild test robot]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git review-wq-dump
head:   c48dd4e1a0d7225c97d7294958dd8ba6be82fde9
commit: 069dcda94642807dc31bf52895bd409512531249 [1/15] bitmap: restructure bitmap_sn[list]printf()
reproduce:
  # apt-get install sparse
  git checkout 069dcda94642807dc31bf52895bd409512531249
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> lib/bitmap.c:574:6: sparse: symbol 'bitmap_print_list' was not declared. Should it be static?
   lib/bitmap.c:1250:30: sparse: incorrect type in assignment (different base types)
   lib/bitmap.c:1250:30:    expected unsigned long [unsigned] [long] <noident>
   lib/bitmap.c:1250:30:    got restricted __le64 [usertype] <noident>
   lib/bitmap.c:1252:30: sparse: incorrect type in assignment (different base types)
   lib/bitmap.c:1252:30:    expected unsigned long [unsigned] [long] <noident>
   lib/bitmap.c:1252:30:    got restricted __le32 [usertype] <noident>

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

[PATCH tj-misc] bitmap: bitmap_print_list() can be static

[kbuild test robot]

lib/bitmap.c:574:6: sparse: symbol 'bitmap_print_list' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 bitmap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bitmap.c b/lib/bitmap.c
index c5dd40e..dc43a01 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -571,7 +571,7 @@ static inline void bscnl_emit(int rbot, int rtop, bool first,
 		printfn(printfn_data, "%d-%d", rbot, rtop);
 }
 
-void bitmap_print_list(const unsigned long *maskp, int nmaskbits,
+static void bitmap_print_list(const unsigned long *maskp, int nmaskbits,
 		       bitmap_printfn_t printfn, void *printfn_data)
 {
 	bool first = true;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>