From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Lameter <cl@linux.com>
Cc: Leonard Crestez <lcrestez@ixiacom.com>, Tejun Heo <tj@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Sorin Dumitru <sdumitru@ixiacom.com>
Subject: Re: [RFC v2] percpu: Add a separate function to merge free areas
Date: Thu, 4 Dec 2014 20:52:02 +0000 [thread overview]
Message-ID: <20141204205202.GP29748@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.11.1412041426230.14577@gentwo.org>
On Thu, Dec 04, 2014 at 02:28:10PM -0600, Christoph Lameter wrote:
> On Thu, 4 Dec 2014, Leonard Crestez wrote:
>
> > Yes, we are actually experiencing issues with this. We create lots of virtual
> > net_devices and routes, which means lots of percpu counters/pointers. In particular
> > we are getting worse performance than in older kernels because the net_device refcnt
> > is now a percpu counter. We could turn that back into a single integer but this
> > would negate an upstream optimization.
>
> Well this is not a common use case and that is not what the per cpu
> allocator was designed for. There is bound to be signifcant fragmentation
> with the current design. The design was for rare allocations when
> structures are initialized.
... except that somebody has not known that and took refcounts on e.g.
vfsmounts into percpu. With massive amounts of hilarity once docker folks
started to test the workloads that created/destroyed those in large amounts.
> > Having a "properly scalable" percpu allocator would be quite nice indeed.
>
> I guess we would be looking at a redesign of the allocator then.
FWIW, I think I've already dealt with most of the crap, but I've no idea
if networking-related callers end up with similar use patterns. For vfsmounts
it seems to suffice...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-12-04 20:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 22:33 Leonard Crestez
2014-12-04 17:57 ` Tejun Heo
2014-12-04 20:10 ` Leonard Crestez
2014-12-04 20:28 ` Christoph Lameter
2014-12-04 20:45 ` Tejun Heo
2014-12-04 20:52 ` Al Viro [this message]
2014-12-04 21:15 ` Christoph Lameter
2014-12-04 21:19 ` Tejun Heo
2014-12-04 21:20 ` Christoph Lameter
2014-12-05 6:25 ` Konstantin Khlebnikov
2014-12-04 20:42 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204205202.GP29748@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=cl@linux.com \
--cc=lcrestez@ixiacom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sdumitru@ixiacom.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox