From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by kanga.kvack.org (Postfix) with ESMTP id 7948B6B0069 for ; Tue, 2 Dec 2014 06:48:30 -0500 (EST) Received: by mail-wi0-f182.google.com with SMTP id h11so20652255wiw.3 for ; Tue, 02 Dec 2014 03:48:29 -0800 (PST) Received: from mail-wg0-x229.google.com (mail-wg0-x229.google.com. [2a00:1450:400c:c00::229]) by mx.google.com with ESMTPS id u2si49709172wiw.103.2014.12.02.03.48.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 02 Dec 2014 03:48:29 -0800 (PST) Received: by mail-wg0-f41.google.com with SMTP id y19so16837228wgg.0 for ; Tue, 02 Dec 2014 03:48:29 -0800 (PST) Date: Tue, 2 Dec 2014 12:48:27 +0100 From: Michal Hocko Subject: Re: [PATCH] mm/memcontrol: fix defined but not used compiler warning Message-ID: <20141202114827.GE27014@dhcp22.suse.cz> References: <20141202110752.GA11327@powerline.azcom-win.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141202110752.GA11327@powerline.azcom-win.it> Sender: owner-linux-mm@kvack.org List-ID: To: Michele Curti Cc: hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Tue 02-12-14 12:07:52, Michele Curti wrote: > test_mem_cgroup_node_reclaimable is used only when MAX_NUMNODES > 1, > so move it into the compiler if statement > > Signed-off-by: Michele Curti Acked-by: Michal Hocko > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index c6ac50e..84531a9 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1615,6 +1615,7 @@ static void mem_cgroup_out_of_memory(struct mem_cgroup *memcg, gfp_t gfp_mask, > oom_kill_process(chosen, gfp_mask, order, points, totalpages, memcg, > NULL, "Memory cgroup out of memory"); > } > +#if MAX_NUMNODES > 1 > > /** > * test_mem_cgroup_node_reclaimable > @@ -1638,7 +1639,6 @@ static bool test_mem_cgroup_node_reclaimable(struct mem_cgroup *memcg, > return false; > > } > -#if MAX_NUMNODES > 1 > > /* > * Always updating the nodemask is not very good - even if we have an empty > -- > 2.1.3 > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org