Re: [mmotm:master 108/319] kernel/events/uprobes.c:319:2: error: implicit declaration of function 'mem_cgroup_charge_anon'

[Fengguang Wu <fengguang.wu@intel.com>]

Hi Andrew,

On Thu, Jun 26, 2014 at 01:02:23PM -0700, Andrew Morton wrote:
> On Thu, 26 Jun 2014 09:05:08 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
> 
> > tree:   git://git.cmpxchg.org/linux-mmotm.git master
> > head:   9477ec75947f2cf0fc47e8ab781a5e9171099be2
> > commit: 5c83b35612a2f2894b54d902ac50612cec2e1926 [108/319] mm: memcontrol: rewrite charge API
> > config: i386-randconfig-ha2-0626 (attached as .config)
> > 
> > Note: the mmotm/master HEAD 9477ec75947f2cf0fc47e8ab781a5e9171099be2 builds fine.
> >       It only hurts bisectibility.
> > 
> > All error/warnings:
> > 
> >    kernel/events/uprobes.c: In function 'uprobe_write_opcode':
> > >> kernel/events/uprobes.c:319:2: error: implicit declaration of function 'mem_cgroup_charge_anon' [-Werror=implicit-function-declaration]
> >      if (mem_cgroup_charge_anon(new_page, mm, GFP_KERNEL))
> >      ^
> >    cc1: some warnings being treated as errors
> 
> The next patch mm-memcontrol-rewrite-charge-api-fix-3.patch fixes this
> up.  Is there something I did which fooled the buildbot's
> hey-theres-a-fixup-patch detector?

Git log shows that the next patch is "kernel: uprobes: switch to new
memcg charge protocol" and in fact there is no
mm-memcontrol-rewrite-charge-api-fix-3.patch at the time this git
branch is created:

                        34346b2c memcg: mem_cgroup_charge_statistics needs preempt_disable
fix 2 =>                ac43603 mm: memcontrol: rewrite uncharge API fix 2
fix 1 =>                0d971aa mm: memcontrol: rewrite uncharge API
                        a9f32f2 kernel: uprobes: switch to new memcg charge protocol
first bad commit =>     5c83b35 mm: memcontrol: rewrite charge API

That should explain why the buildbot reported the error out.

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>