From: Johannes Weiner <hannes@cmpxchg.org>
To: Weijie Yang <weijie.yang@samsung.com>
Cc: 'Andrew Morton' <akpm@linux-foundation.org>,
mgorman@suse.de, 'Rik van Riel' <riel@redhat.com>,
'Weijie Yang' <weijie.yang.kh@gmail.com>,
'Linux-MM' <linux-mm@kvack.org>,
'linux-kernel' <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: mincore: add hwpoison page handle
Date: Wed, 12 Nov 2014 09:20:22 -0500 [thread overview]
Message-ID: <20141112142022.GA29766@phnom.home.cmpxchg.org> (raw)
In-Reply-To: <000001cffe2a$66a95a50$33fc0ef0$%yang@samsung.com>
On Wed, Nov 12, 2014 at 11:39:29AM +0800, Weijie Yang wrote:
> When encounter pte is a swap entry, the current code handles two cases:
> migration and normal swapentry, but we have a third case: hwpoison page.
>
> This patch adds hwpoison page handle, consider hwpoison page incore as
> same as migration.
>
> Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
The change makes sense:
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
But please add a description of what happens when a poison entry is
encountered with the current code. I'm guessing swap_address_space()
will return garbage and this might crash the kernel?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-11-12 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 3:39 Weijie Yang
2014-11-12 14:20 ` Johannes Weiner [this message]
2014-11-14 1:02 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112142022.GA29766@phnom.home.cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
--cc=weijie.yang.kh@gmail.com \
--cc=weijie.yang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox