From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by kanga.kvack.org (Postfix) with ESMTP id B9B316B00DB for ; Mon, 3 Nov 2014 03:00:30 -0500 (EST) Received: by mail-pa0-f51.google.com with SMTP id kq14so11772833pab.10 for ; Mon, 03 Nov 2014 00:00:30 -0800 (PST) Received: from lgeamrelo01.lge.com (lgeamrelo01.lge.com. [156.147.1.125]) by mx.google.com with ESMTP id co6si14796241pac.88.2014.11.03.00.00.27 for ; Mon, 03 Nov 2014 00:00:29 -0800 (PST) Date: Mon, 3 Nov 2014 17:02:08 +0900 From: Joonsoo Kim Subject: Re: [patch 1/3] mm: embed the memcg pointer directly into struct page Message-ID: <20141103080208.GA7052@js1304-P5Q-DELUXE> References: <1414898156-4741-1-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1414898156-4741-1-git-send-email-hannes@cmpxchg.org> Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , Vladimir Davydov , Tejun Heo , David Miller , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org On Sat, Nov 01, 2014 at 11:15:54PM -0400, Johannes Weiner wrote: > Memory cgroups used to have 5 per-page pointers. To allow users to > disable that amount of overhead during runtime, those pointers were > allocated in a separate array, with a translation layer between them > and struct page. Hello, Johannes. I'd like to leave this translation layer. Could you just disable that code with #ifdef until next user comes? In our company, we uses PAGE_OWNER on mm tree which is the feature saying who allocates the page. To use PAGE_OWNER needs modifying struct page and then needs re-compile. This re-compile makes us difficult to use this feature. So, we decide to implement run-time configurable PAGE_OWNER through page_cgroup's translation layer code. Moreover, with this infrastructure, I plan to implement some other debugging feature. Because of my laziness, it didn't submitted to LKML. But, I will submit it as soon as possible. If the code is removed, I would copy-and-paste the code, but, it would cause lose of the history on that code. So if possible, I'd like to leave that code now. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org