From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f177.google.com (mail-pd0-f177.google.com [209.85.192.177]) by kanga.kvack.org (Postfix) with ESMTP id 341AD6B0072 for ; Sat, 1 Nov 2014 14:05:59 -0400 (EDT) Received: by mail-pd0-f177.google.com with SMTP id v10so8982563pde.8 for ; Sat, 01 Nov 2014 11:05:58 -0700 (PDT) Received: from shards.monkeyblade.net (shards.monkeyblade.net. [2001:4f8:3:36:211:85ff:fe63:a549]) by mx.google.com with ESMTP id dn10si4654534pdb.70.2014.11.01.11.05.57 for ; Sat, 01 Nov 2014 11:05:57 -0700 (PDT) Date: Sat, 01 Nov 2014 14:05:54 -0400 (EDT) Message-Id: <20141101.140554.427928361730485371.davem@davemloft.net> Subject: Re: [PATCH V4 1/2] mm: Update generic gup implementation to handle hugepage directory From: David Miller In-Reply-To: <1414570785-18966-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1414570785-18966-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: aneesh.kumar@linux.vnet.ibm.com Cc: akpm@linux-foundation.org, steve.capper@linaro.org, aarcange@redhat.com, benh@kernel.crashing.org, mpe@ellerman.id.au, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org From: "Aneesh Kumar K.V" Date: Wed, 29 Oct 2014 13:49:44 +0530 > +/* > + * Some architectures requires a hugepage directory format that is > + * required to support multiple hugepage sizes. For example > + * a4fe3ce7699bfe1bd88f816b55d42d8fe1dac655 introduced the same > + * on powerpc. This allows for a more flexible hugepage pagetable > + * layout. > + */ Please don't put commit IDs into the actual code. If that commit gets backported to -stable or another tree, then this comment will send someone on a wild goose chase. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org