From: Oleg Nesterov <oleg@redhat.com>
To: Alex Thorlton <athorlton@sgi.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Bob Liu <lliubbo@gmail.com>, David Rientjes <rientjes@google.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Hugh Dickins <hughd@google.com>, Ingo Molnar <mingo@redhat.com>,
Kees Cook <keescook@chromium.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Rik van Riel <riel@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Vladimir Davydov <vdavydov@parallels.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Add pgcollapse controls to task_struct
Date: Thu, 23 Oct 2014 21:37:06 +0200 [thread overview]
Message-ID: <20141023193706.GB6751@redhat.com> (raw)
In-Reply-To: <1414089963-73165-3-git-send-email-athorlton@sgi.com>
On 10/23, Alex Thorlton wrote:
>
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -1661,6 +1661,18 @@ struct task_struct {
> unsigned int sequential_io;
> unsigned int sequential_io_avg;
> #endif
> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> + struct callback_head pgcollapse_work;
> + /* default scan 8*512 pte (or vmas) every 30 second */
> + unsigned int pgcollapse_pages_to_scan;
> + unsigned int pgcollapse_pages_collapsed;
> + unsigned int pgcollapse_full_scans;
> + unsigned int pgcollapse_scan_sleep_millisecs;
> + /* during fragmentation poll the hugepage allocator once every minute */
> + unsigned int pgcollapse_alloc_sleep_millisecs;
> + unsigned long pgcollapse_last_scan;
> + unsigned long pgcollapse_scan_address;
> +#endif
Shouldn't this all live in mm_struct?
Except pgcollapse_work can't, exit_mm() called before exit_mm(). Probably
it can be allocated.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-10-23 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 18:45 [RESEND] [PATCH 0/4] Convert khugepaged to a task_work function Alex Thorlton
2014-10-23 18:46 ` [PATCH 1/4] Disable khugepaged thread Alex Thorlton
2014-10-23 18:46 ` [PATCH 2/4] Add pgcollapse controls to task_struct Alex Thorlton
2014-10-23 19:37 ` Oleg Nesterov [this message]
2014-10-23 18:46 ` [PATCH 3/4] Convert khugepaged scan functions to work with task_work Alex Thorlton
2014-10-23 19:32 ` Oleg Nesterov
2014-10-23 18:46 ` [PATCH 4/4] Add /proc files to expose per-mm pgcollapse stats Alex Thorlton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023193706.GB6751@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=athorlton@sgi.com \
--cc=ebiederm@xmission.com \
--cc=hughd@google.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox