From: Andrew Morton <akpm@linux-foundation.org>
To: Pintu Kumar <pintu.k@samsung.com>
Cc: riel@redhat.com, aquini@redhat.com, paul.gortmaker@windriver.com,
jmarchan@redhat.com, lcapitulino@redhat.com,
kirill.shutemov@linux.intel.com, m.szyprowski@samsung.com,
aneesh.kumar@linux.vnet.ibm.com, iamjoonsoo.kim@lge.com,
mina86@mina86.com, lauraa@codeaurora.org, gioh.kim@lge.com,
mgorman@suse.de, rientjes@google.com, hannes@cmpxchg.org,
vbabka@suse.cz, sasha.levin@oracle.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
pintu_agarwal@yahoo.com, cpgs@samsung.com, vishnu.ps@samsung.com,
rohit.kr@samsung.com, ed.savinay@samsung.com
Subject: Re: [PATCH v2 2/2] fs: proc: Include cma info in proc/meminfo
Date: Wed, 22 Oct 2014 13:00:46 -0700 [thread overview]
Message-ID: <20141022130046.f4c7bb9cfc5805d2bef188a4@linux-foundation.org> (raw)
In-Reply-To: <1413986796-19732-2-git-send-email-pintu.k@samsung.com>
On Wed, 22 Oct 2014 19:36:35 +0530 Pintu Kumar <pintu.k@samsung.com> wrote:
> This patch include CMA info (CMATotal, CMAFree) in /proc/meminfo.
> Currently, in a CMA enabled system, if somebody wants to know the
> total CMA size declared, there is no way to tell, other than the dmesg
> or /var/log/messages logs.
> With this patch we are showing the CMA info as part of meminfo, so that
> it can be determined at any point of time.
> This will be populated only when CMA is enabled.
Fair enough.
We should be pretty careful about what we put in meminfo - it's the
top-level, most-important procfs file and I expect that quite a lot of
userspace reads it with some frequency. We don't want to clutter it
up. /proc/vmstat is a suitable place for the less important info which
is more kernel developer oriented.
But CMATotal and CMAFree do pass the "should be in meminfo" test, IMO.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-10-22 20:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 7:33 [PATCH] mm: cma: split cma-reserved in dmesg log Pintu Kumar
2014-10-20 9:35 ` Michal Nazarewicz
2014-10-20 22:48 ` Andrew Morton
2014-10-21 0:47 ` Gioh Kim
2014-10-21 13:21 ` PINTU KUMAR
2014-10-21 23:55 ` Gioh Kim
2014-10-22 14:06 ` [PATCH v2 1/2] " Pintu Kumar
2014-10-22 14:06 ` [PATCH v2 2/2] fs: proc: Include cma info in proc/meminfo Pintu Kumar
2014-10-22 20:00 ` Andrew Morton [this message]
2014-10-23 0:19 ` Gioh Kim
2014-10-24 8:57 ` PINTU KUMAR
2014-10-24 10:10 ` Gioh Kim
2014-10-24 10:43 ` PINTU KUMAR
2014-10-24 16:31 ` Michal Nazarewicz
2014-10-27 23:15 ` Andrew Morton
2014-10-23 17:01 ` [PATCH v2 1/2] mm: cma: split cma-reserved in dmesg log Michal Nazarewicz
2014-10-24 10:30 ` PINTU KUMAR
2014-10-24 16:32 ` Michal Nazarewicz
2014-11-03 23:57 ` David Rientjes
2014-11-04 17:15 ` PINTU KUMAR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022130046.f4c7bb9cfc5805d2bef188a4@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=aquini@redhat.com \
--cc=cpgs@samsung.com \
--cc=ed.savinay@samsung.com \
--cc=gioh.kim@lge.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jmarchan@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=lauraa@codeaurora.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=mina86@mina86.com \
--cc=paul.gortmaker@windriver.com \
--cc=pintu.k@samsung.com \
--cc=pintu_agarwal@yahoo.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=rohit.kr@samsung.com \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
--cc=vishnu.ps@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox