From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Jeremiah Mahler <jmmahler@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] [PATCH 1/3] mm/slab: use percpu allocator for cpu cache
Date: Mon, 29 Sep 2014 16:44:18 +0900 [thread overview]
Message-ID: <20140929074418.GA29310@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <20140928062449.GA1277@hudson.localdomain>
On Sat, Sep 27, 2014 at 11:24:49PM -0700, Jeremiah Mahler wrote:
> On Thu, Aug 21, 2014 at 05:11:13PM +0900, Joonsoo Kim wrote:
> > Because of chicken and egg problem, initializaion of SLAB is really
> > complicated. We need to allocate cpu cache through SLAB to make
> > the kmem_cache works, but, before initialization of kmem_cache,
> > allocation through SLAB is impossible.
> >
> > On the other hand, SLUB does initialization with more simple way. It
> > uses percpu allocator to allocate cpu cache so there is no chicken and
> > egg problem.
> >
> > So, this patch try to use percpu allocator in SLAB. This simplify
> > initialization step in SLAB so that we could maintain SLAB code more
> > easily.
> >
> > From my testing, there is no performance difference.
> >
> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
> I just encountered a problem on a Lenovo Carbon X1 where it will
> suspend but won't resume. A bisect indicated that this patch
> is causing the problem.
>
> 997888488ef92da365b870247de773255227ce1f
>
> I imagine the patch author, Joonsoo Kim, might have a better idea
> why this is happening than I do. But if I can provide any information
> or run any tests that might be of help just let me know.
Hello,
Yeah, there is a bug. Below will fix your issue.
Could you test it and report the result?
Thanks for reporting it.
--------->8---------------
prev parent reply other threads:[~2014-09-29 7:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 8:11 Joonsoo Kim
2014-08-21 8:11 ` [PATCH 2/3] mm/slab_common: commonize slab merge logic Joonsoo Kim
2014-08-21 14:22 ` Christoph Lameter
2014-08-25 8:26 ` Joonsoo Kim
2014-08-25 15:27 ` Christoph Lameter
2014-08-26 2:23 ` Joonsoo Kim
2014-08-26 21:23 ` Christoph Lameter
2014-08-21 8:11 ` [PATCH 3/3] mm/slab: support slab merge Joonsoo Kim
2014-08-25 15:29 ` Christoph Lameter
2014-08-26 2:26 ` Joonsoo Kim
2014-08-21 14:21 ` [PATCH 1/3] mm/slab: use percpu allocator for cpu cache Christoph Lameter
2014-08-25 8:26 ` Joonsoo Kim
2014-08-25 13:13 ` Christoph Lameter
2014-08-26 2:19 ` Joonsoo Kim
2014-08-26 21:22 ` Christoph Lameter
2014-08-27 23:37 ` Christoph Lameter
2014-09-01 0:19 ` Joonsoo Kim
2014-09-28 6:24 ` [REGRESSION] " Jeremiah Mahler
2014-09-28 16:38 ` Christoph Lameter
2014-09-29 7:44 ` Joonsoo Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929074418.GA29310@js1304-P5Q-DELUXE \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=jmmahler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox