From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f177.google.com (mail-lb0-f177.google.com [209.85.217.177]) by kanga.kvack.org (Postfix) with ESMTP id 609736B0036 for ; Mon, 22 Sep 2014 09:48:32 -0400 (EDT) Received: by mail-lb0-f177.google.com with SMTP id z12so6638882lbi.8 for ; Mon, 22 Sep 2014 06:48:31 -0700 (PDT) Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id w4si14497202lag.128.2014.09.22.06.48.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 22 Sep 2014 06:48:30 -0700 (PDT) Date: Mon, 22 Sep 2014 15:48:27 +0200 From: Michal Hocko Subject: Re: [PATCH] cgroup/kmemleak: add kmemleak_free() for cgroup deallocations. Message-ID: <20140922134827.GD336@dhcp22.suse.cz> References: <1411004285-42101-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1411004285-42101-1-git-send-email-wangnan0@huawei.com> Sender: owner-linux-mm@kvack.org List-ID: To: Wang Nan Cc: Johannes Weiner , Steven Rostedt , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Li Zefan On Thu 18-09-14 09:38:05, Wang Nan wrote: > Commit ff7ee93f4 introduces kmemleak_alloc() for alloc_page_cgroup(), > but corresponding kmemleak_free() is missing, which makes kmemleak be > wrongly disabled after memory offlining. Log is pasted at the end of > this commit message. > > This patch add kmemleak_free() into free_page_cgroup(). During page > offlining, this patch removes corresponding entries in kmemleak rbtree. > After that, the freed memory can be allocated again by other subsystems > without killing kmemleak. > > bash # for x in 1 2 3 4; do echo offline > /sys/devices/system/memory/memory$x/state ; sleep 1; done ; dmesg | grep leak > [ 45.537934] Offlined Pages 32768 > [ 46.617892] kmemleak: Cannot insert 0xffff880016969000 into the object search tree (overlaps existing) > [ 46.617892] CPU: 0 PID: 412 Comm: sleep Not tainted 3.17.0-rc5+ #86 > [ 46.617892] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 > [ 46.617892] ffff880016823d10 ffff880018bdfc38 ffffffff81725d2c ffff88001780e950 > [ 46.617892] ffff880016969000 ffff880018bdfc88 ffffffff8117a9e6 ffff880018bdfc78 > [ 46.617892] 0000000000000096 ffff880017812800 ffffffff81c2eda0 ffff880016969000 > [ 46.617892] Call Trace: > [ 46.617892] [] dump_stack+0x46/0x58 > [ 46.617892] [] create_object+0x266/0x2c0 > [ 46.617892] [] kmemleak_alloc+0x26/0x50 > [ 46.617892] [] kmem_cache_alloc+0xd3/0x160 > [ 46.617892] [] __sigqueue_alloc+0x49/0xd0 > [ 46.617892] [] __send_signal+0xcb/0x410 > [ 46.617892] [] send_signal+0x45/0x90 > [ 46.617892] [] __group_send_sig_info+0x13/0x20 > [ 46.617892] [] do_notify_parent+0x1bb/0x260 > [ 46.617892] [] ? sched_move_task+0xaa/0x130 > [ 46.617892] [] do_exit+0x767/0xa40 > [ 46.617892] [] do_group_exit+0x44/0xa0 > [ 46.617892] [] SyS_exit_group+0x17/0x20 > [ 46.617892] [] system_call_fastpath+0x16/0x1b > [ 46.617892] kmemleak: Kernel memory leak detector disabled > [ 46.617892] kmemleak: Object 0xffff880016900000 (size 524288): > [ 46.617892] kmemleak: comm "swapper/0", pid 0, jiffies 4294667296 > [ 46.617892] kmemleak: min_count = 0 > [ 46.617892] kmemleak: count = 0 > [ 46.617892] kmemleak: flags = 0x1 > [ 46.617892] kmemleak: checksum = 0 > [ 46.617892] kmemleak: backtrace: > [ 46.617892] [] log_early+0x63/0x77 > [ 46.617892] [] kmemleak_alloc+0x4b/0x50 > [ 46.617892] [] init_section_page_cgroup+0x7f/0xf5 > [ 46.617892] [] page_cgroup_init+0xc5/0xd0 > [ 46.617892] [] start_kernel+0x333/0x408 > [ 46.617892] [] x86_64_start_reservations+0x2a/0x2c > [ 46.617892] [] x86_64_start_kernel+0xf5/0xfc > [ 46.617892] [] 0xffffffffffffffff > > Signed-off-by: Wang Nan > Cc: Steven Rostedt Acked-by: Michal Hocko And sorry, I should have noticed that when reviewing the original patch which added kmemleak_alloc. I think this is worth going into stable. The risk is marginal and somebody might be relying on kmemleak even on older kernels when debugging a bug during memory hotplug. Thanks! > --- > mm/page_cgroup.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c > index 3708264..5331c2b 100644 > --- a/mm/page_cgroup.c > +++ b/mm/page_cgroup.c > @@ -171,6 +171,7 @@ static void free_page_cgroup(void *addr) > sizeof(struct page_cgroup) * PAGES_PER_SECTION; > > BUG_ON(PageReserved(page)); > + kmemleak_free(addr); > free_pages_exact(addr, table_size); > } > } > -- > 1.8.4 > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org