From: Peter Zijlstra <peterz@infradead.org>
To: NeilBrown <neilb@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Ingo Molnar <mingo@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeff Layton <jeff.layton@primarydata.com>
Subject: Re: [PATCH 1/4] SCHED: add some "wait..on_bit...timeout()" interfaces.
Date: Thu, 18 Sep 2014 16:42:22 +0200 [thread overview]
Message-ID: <20140918144222.GP2840@worktop.localdomain> (raw)
In-Reply-To: <20140916053134.22257.28841.stgit@notabene.brown>
On Tue, Sep 16, 2014 at 03:31:35PM +1000, NeilBrown wrote:
> In commit c1221321b7c25b53204447cff9949a6d5a7ddddc
> sched: Allow wait_on_bit_action() functions to support a timeout
>
> I suggested that a "wait_on_bit_timeout()" interface would not meet my
> need. This isn't true - I was just over-engineering.
>
> Including a 'private' field in wait_bit_key instead of a focused
> "timeout" field was just premature generalization. If some other
> use is ever found, it can be generalized or added later.
>
> So this patch renames "private" to "timeout" with a meaning "stop
> waiting when "jiffies" reaches or passes "timeout",
> and adds two of the many possible wait..bit..timeout() interfaces:
>
> wait_on_page_bit_killable_timeout(), which is the one I want to use,
> and out_of_line_wait_on_bit_timeout() which is a reasonably general
> example. Others can be added as needed.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
> include/linux/pagemap.h | 2 ++
> include/linux/wait.h | 5 ++++-
> kernel/sched/wait.c | 36 ++++++++++++++++++++++++++++++++++++
> mm/filemap.c | 13 +++++++++++++
> 4 files changed, 55 insertions(+), 1 deletion(-)
>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-09-18 14:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 5:31 [PATCH 0/4] Remove possible deadlocks in nfs_release_page() NeilBrown
2014-09-16 5:31 ` [PATCH 4/4] NFS/SUNRPC: Remove other deadlock-avoidance mechanisms " NeilBrown
2014-09-16 22:04 ` Trond Myklebust
2014-09-17 1:10 ` NeilBrown
2014-09-17 1:32 ` Trond Myklebust
2014-09-17 3:12 ` NeilBrown
2014-09-16 5:31 ` [PATCH 2/4] MM: export page_wakeup functions NeilBrown
2014-09-16 5:31 ` [PATCH 3/4] NFS: avoid deadlocks with loop-back mounted NFS filesystems NeilBrown
2014-09-16 12:39 ` Anna Schumaker
2014-09-16 23:37 ` NeilBrown
2014-09-16 5:31 ` [PATCH 1/4] SCHED: add some "wait..on_bit...timeout()" interfaces NeilBrown
2014-09-18 14:42 ` Peter Zijlstra [this message]
2014-09-23 2:10 ` NeilBrown
2014-09-23 21:30 ` Andrew Morton
2014-09-16 11:47 ` [PATCH 0/4] Remove possible deadlocks in nfs_release_page() Jeff Layton
2014-09-16 23:41 ` NeilBrown
2014-09-17 0:19 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140918144222.GP2840@worktop.localdomain \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jeff.layton@primarydata.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox