From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by kanga.kvack.org (Postfix) with ESMTP id 1568A6B0035 for ; Wed, 17 Sep 2014 14:31:12 -0400 (EDT) Received: by mail-wg0-f43.google.com with SMTP id x12so1811428wgg.2 for ; Wed, 17 Sep 2014 11:31:12 -0700 (PDT) Received: from gum.cmpxchg.org (gum.cmpxchg.org. [85.214.110.215]) by mx.google.com with ESMTPS id de9si29265542wjb.109.2014.09.17.11.30.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Sep 2014 11:31:11 -0700 (PDT) Date: Wed, 17 Sep 2014 14:30:49 -0400 From: Johannes Weiner Subject: Re: [PATCH] mm: page_alloc: Make paranoid check in move_freepages a VM_BUG_ON Message-ID: <20140917183049.GB32607@cmpxchg.org> References: <20140909145228.GB12309@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140909145228.GB12309@suse.de> Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Andrew Morton , Rik van Riel , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Tue, Sep 09, 2014 at 03:52:28PM +0100, Mel Gorman wrote: > Since 2.6.24 there has been a paranoid check in move_freepages that looks > up the zone of two pages. This is a very slow path and the only time I've > seen this bug trigger recently is when memory initialisation was broken > during patch development. Despite the fact it's a slow path, this patch > converts the check to a VM_BUG_ON anyway as it is served its purpose by now. > > Signed-off-by: Mel Gorman Acked-by: Johannes Weiner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org