From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: "Wang, Yalin" <Yalin.Wang@sonymobile.com>,
Will Deacon <Will.Deacon@arm.com>,
"'linux-mm@kvack.org'" <linux-mm@kvack.org>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'linux-arm-kernel@lists.infradead.org'"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64:free_initrd_mem should also free the memblock
Date: Wed, 17 Sep 2014 19:12:54 +0100 [thread overview]
Message-ID: <20140917181254.GW12361@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20140917162822.GB15261@e104818-lin.cambridge.arm.com>
On Wed, Sep 17, 2014 at 05:28:23PM +0100, Catalin Marinas wrote:
> On Tue, Sep 16, 2014 at 02:53:55AM +0100, Wang, Yalin wrote:
> > The reason that a want merge this patch is that
> > It confuse me when I debug memory issue by
> > /sys/kernel/debug/memblock/reserved debug file,
> > It show lots of un-correct reserved memory.
> > In fact, I also send a patch to cma driver part
> > For this issue too:
> > http://ozlabs.org/~akpm/mmots/broken-out/free-the-reserved-memblock-when-free-cma-pages.patch
> >
> > I want to remove these un-correct memblock parts as much as possible,
> > so that I can see more correct info from /sys/kernel/debug/memblock/reserved
> > debug file .
>
> Could we not always call memblock_free() from free_reserved_area() (with
> a dummy definition when !CONFIG_HAVE_MEMBLOCK)?
Why bother?
The next thing is that people will want to have memblock's reserved areas
track whether the kernel allocates a page so that the memblock debugging
follows the kernel's allocation state.
This is utterly rediculous. Memblock is purely a method to get the system
up and running. Once it hands memory over to the normal kernel allocators,
the reservation information in memblock is no longer valid.
The /useful/ information that it provides is the state of memory passed
over to the kernel allocators, which in itself is valuable information.
Destroying it by freeing stuff after that point is not useful.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-09-17 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 10:17 Wang, Yalin
2014-09-15 18:33 ` Will Deacon
2014-09-15 18:40 ` Russell King - ARM Linux
2014-09-15 18:50 ` Will Deacon
2014-09-16 1:53 ` Wang, Yalin
2014-09-17 16:28 ` Catalin Marinas
2014-09-17 18:12 ` Russell King - ARM Linux [this message]
2014-09-18 9:38 ` Wang, Yalin
2014-09-18 9:59 ` Russell King - ARM Linux
2014-09-18 12:13 ` Wang, Yalin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917181254.GW12361@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Will.Deacon@arm.com \
--cc=Yalin.Wang@sonymobile.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox