From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by kanga.kvack.org (Postfix) with ESMTP id 888CD6B0036 for ; Fri, 5 Sep 2014 16:01:05 -0400 (EDT) Received: by mail-pa0-f47.google.com with SMTP id ey11so773826pad.6 for ; Fri, 05 Sep 2014 13:01:05 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id tx5si5645440pac.226.2014.09.05.13.01.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Sep 2014 13:01:04 -0700 (PDT) Date: Fri, 5 Sep 2014 13:01:02 -0700 From: Andrew Morton Subject: Re: [PATCH -mmotm] mm: fix kmemcheck.c build errors Message-Id: <20140905130102.f6b8866115f83a0bacedb899@linux-foundation.org> In-Reply-To: <1409902086-32311-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1409902086-32311-1-git-send-email-iamjoonsoo.kim@lge.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, sfr@canb.auug.org.au, mhocko@suse.cz, Pekka Enberg , Vegard Nossum , Christoph Lameter , David Rientjes , Randy Dunlap On Fri, 5 Sep 2014 16:28:06 +0900 Joonsoo Kim wrote: > mm-slab_common-move-kmem_cache-definition-to-internal-header.patch > in mmotm makes following build failure. > > ../mm/kmemcheck.c:70:7: error: dereferencing pointer to incomplete type > ../mm/kmemcheck.c:83:15: error: dereferencing pointer to incomplete type > ../mm/kmemcheck.c:95:8: error: dereferencing pointer to incomplete type > ../mm/kmemcheck.c:95:21: error: dereferencing pointer to incomplete type > > ../mm/slab.h: In function 'cache_from_obj': > ../mm/slab.h:283:2: error: implicit declaration of function > 'memcg_kmem_enabled' [-Werror=implicit-function-declaration] > > Add header files to fix kmemcheck.c build errors. > > [iamjoonsoo.kim@lge.com] move up memcontrol.h header > to fix build failure if CONFIG_MEMCG_KMEM=y too. Looking at this line > Signed-off-by: Randy Dunlap and at this line > Signed-off-by: Joonsoo Kim I am suspecting that this patch was authored by Randy. But there was no From: line at start-of-changelog to communicate this? > diff --git a/mm/slab.h b/mm/slab.h > index 13845d0..963a3f8 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -37,6 +37,8 @@ struct kmem_cache { > #include > #endif > > +#include > + > /* > * State of the slab allocator. > * It seems a bit wrong to include a fairly high-level memcontol.h into a fairly low-level slab.h, but I expect it will work. I can't really see how mm-slab_common-move-kmem_cache-definition-to-internal-header.patch caused the breakage. I don't know how you were triggering this build failure - please always include such info in the changelogs. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org