From: Andrew Morton <akpm@linux-foundation.org>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-next@vger.kernel.org, sfr@canb.auug.org.au, mhocko@suse.cz,
Pekka Enberg <penberg@kernel.org>,
Vegard Nossum <vegardno@ifi.uio.no>,
Christoph Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH -mmotm] mm: fix kmemcheck.c build errors
Date: Fri, 5 Sep 2014 13:01:02 -0700 [thread overview]
Message-ID: <20140905130102.f6b8866115f83a0bacedb899@linux-foundation.org> (raw)
In-Reply-To: <1409902086-32311-1-git-send-email-iamjoonsoo.kim@lge.com>
On Fri, 5 Sep 2014 16:28:06 +0900 Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
> mm-slab_common-move-kmem_cache-definition-to-internal-header.patch
> in mmotm makes following build failure.
>
> ../mm/kmemcheck.c:70:7: error: dereferencing pointer to incomplete type
> ../mm/kmemcheck.c:83:15: error: dereferencing pointer to incomplete type
> ../mm/kmemcheck.c:95:8: error: dereferencing pointer to incomplete type
> ../mm/kmemcheck.c:95:21: error: dereferencing pointer to incomplete type
>
> ../mm/slab.h: In function 'cache_from_obj':
> ../mm/slab.h:283:2: error: implicit declaration of function
> 'memcg_kmem_enabled' [-Werror=implicit-function-declaration]
>
> Add header files to fix kmemcheck.c build errors.
>
> [iamjoonsoo.kim@lge.com] move up memcontrol.h header
> to fix build failure if CONFIG_MEMCG_KMEM=y too.
Looking at this line
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
and at this line
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
I am suspecting that this patch was authored by Randy. But there was
no From: line at start-of-changelog to communicate this?
> diff --git a/mm/slab.h b/mm/slab.h
> index 13845d0..963a3f8 100644
> --- a/mm/slab.h
> +++ b/mm/slab.h
> @@ -37,6 +37,8 @@ struct kmem_cache {
> #include <linux/slub_def.h>
> #endif
>
> +#include <linux/memcontrol.h>
> +
> /*
> * State of the slab allocator.
> *
It seems a bit wrong to include a fairly high-level memcontol.h into a
fairly low-level slab.h, but I expect it will work.
I can't really see how
mm-slab_common-move-kmem_cache-definition-to-internal-header.patch
caused the breakage. I don't know how you were triggering this build
failure - please always include such info in the changelogs.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-09-05 20:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 7:28 Joonsoo Kim
2014-09-05 20:01 ` Andrew Morton [this message]
2014-09-15 1:49 ` Joonsoo Kim
-- strict thread matches above, loose matches on Subject: below --
2014-08-29 22:16 mmotm 2014-08-29-15-15 uploaded akpm
2014-08-30 1:48 ` [PATCH -mmotm] mm: fix kmemcheck.c build errors Randy Dunlap
2014-08-31 11:36 ` Andrey Ryabinin
2014-08-31 14:48 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905130102.f6b8866115f83a0bacedb899@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=penberg@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=vegardno@ifi.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox