From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f177.google.com (mail-pd0-f177.google.com [209.85.192.177]) by kanga.kvack.org (Postfix) with ESMTP id 40E9F6B0035 for ; Fri, 8 Aug 2014 03:19:06 -0400 (EDT) Received: by mail-pd0-f177.google.com with SMTP id p10so6489622pdj.8 for ; Fri, 08 Aug 2014 00:19:05 -0700 (PDT) Received: from lgeamrelo01.lge.com (lgeamrelo01.lge.com. [156.147.1.125]) by mx.google.com with ESMTP id si3si5372543pac.158.2014.08.08.00.19.03 for ; Fri, 08 Aug 2014 00:19:05 -0700 (PDT) Date: Fri, 8 Aug 2014 16:19:03 +0900 From: Joonsoo Kim Subject: Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC) Message-ID: <20140808071903.GD6150@js1304-P5Q-DELUXE> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Geert Uytterhoeven Cc: Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Linux MM , "linux-kernel@vger.kernel.org" , Vladimir Davydov On Thu, Aug 07, 2014 at 10:03:09PM +0900, Joonsoo Kim wrote: > 2014-08-07 21:53 GMT+09:00 Geert Uytterhoeven : > > Hi, > > > > On Thu, Aug 7, 2014 at 2:36 PM, Joonsoo Kim wrote: > >>> With latest mainline, I'm getting a crash during bootup on m68k/ARAnyM: > >>> > >>> enable_cpucache failed for radix_tree_node, error 12. > >>> kernel BUG at /scratch/geert/linux/linux-m68k/mm/slab.c:1522! > > > >>> I bisected it to commit a640616822b2c3a8009b0600f20c4a76ea8a0025 > >>> Author: Joonsoo Kim > >>> Date: Wed Aug 6 16:04:38 2014 -0700 > >>> > >>> slab: remove BAD_ALIEN_MAGIC > > > >> This patch only works for !NUMA. And if num_possible_nodes() is 1, > >> then it doesn't have any effect, because alloc_alien_cache() call is always > >> skipped. Is it possible !NUMA and num_possible_nodes() != 1? > >> > >> Could you check your config for CONFIG_NUMA and > >> CONFIG_NODES_SHIFT? > > > > $ grep CONFIG_NUMA .config > > $ grep CONFIG_NODES_SHIFT .config > > CONFIG_NODES_SHIFT=3 > > $ > > > > There are indeed multiple nodes: > > > > On node 0 totalpages: 3584 > > free_area_init_node: node 0, pgdat 003659a4, node_mem_map 00402000 > > DMA zone: 32 pages used for memmap > > DMA zone: 0 pages reserved > > DMA zone: 3584 pages, LIFO batch:0 > > On node 1 totalpages: 65536 > > free_area_init_node: node 1, pgdat 00366294, node_mem_map 00426090 > > DMA zone: 576 pages used for memmap > > DMA zone: 0 pages reserved > > DMA zone: 65536 pages, LIFO batch:15 > > > >> And, could you check booting with boot param "noaliencache"? > > > > That fixes the boot, too. > > Ah... I don't know it can be possible to be !CONFIG_NUMA and > CONFIG_NODES_SHIFT > 0 until now. If so, I should revert this patch. > > After some more investigation, I will revert this patch tomorrow and > notify you. > > Thanks for reporting!!! :) Hello, Just for curiosity. Could you show me your full dmesg on boot-up? What I want to know is nodes-cpus mapping. I looked at SLAB code and found that SLAB works fine only if numa_mem_id() always returns 0. I guess that this is the case for !CONFIG_NUMA, so your system would work fine. And, I looked at SLUB code and found that SLUB works fine only if page_to_nid(page) always return 0 for this !CONFIG_NUMA and many nodes case. If not, some memory could be leak, I guess. If possible, could you check whether page_to_nid(page) returns only 0 or not? Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org