From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by kanga.kvack.org (Postfix) with ESMTP id 9ACD36B0035 for ; Fri, 8 Aug 2014 02:22:10 -0400 (EDT) Received: by mail-pa0-f46.google.com with SMTP id lj1so6709224pab.5 for ; Thu, 07 Aug 2014 23:22:10 -0700 (PDT) Received: from lgeamrelo02.lge.com (lgeamrelo02.lge.com. [156.147.1.126]) by mx.google.com with ESMTP id nu1si5241458pbb.216.2014.08.07.23.22.08 for ; Thu, 07 Aug 2014 23:22:09 -0700 (PDT) Date: Fri, 8 Aug 2014 15:22:07 +0900 From: Joonsoo Kim Subject: Re: [PATCH v2 2/8] mm/isolation: remove unstable check for isolated page Message-ID: <20140808062206.GA6150@js1304-P5Q-DELUXE> References: <1407309517-3270-1-git-send-email-iamjoonsoo.kim@lge.com> <1407309517-3270-4-git-send-email-iamjoonsoo.kim@lge.com> <53E383DD.6090500@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53E383DD.6090500@suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka Cc: Andrew Morton , "Kirill A. Shutemov" , Rik van Riel , Mel Gorman , Johannes Weiner , Minchan Kim , Yasuaki Ishimatsu , Zhang Yanfei , "Srivatsa S. Bhat" , Tang Chen , Naoya Horiguchi , Bartlomiej Zolnierkiewicz , Wen Congyang , Marek Szyprowski , Michal Nazarewicz , Laura Abbott , Heesub Shin , "Aneesh Kumar K.V" , Ritesh Harjani , t.stanislaws@samsung.com, Gioh Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Thu, Aug 07, 2014 at 03:49:17PM +0200, Vlastimil Babka wrote: > On 08/06/2014 09:18 AM, Joonsoo Kim wrote: > >The check '!PageBuddy(page) && page_count(page) == 0 && > >migratetype == MIGRATE_ISOLATE' would mean the page on free processing. > > What is "the page on free processing"? I thought this test means the > page is on some CPU's pcplist? Yes, you are right. > > >Although it could go into buddy allocator within a short time, > >futher operation such as isolate_freepages_range() in CMA, called after > >test_page_isolated_in_pageblock(), could be failed due to this unstability > > By "unstability" you mean the page can be allocated again from the > pcplist instead of being freed to buddy list? Yes. > >since it requires that the page is on buddy. I think that removing > >this unstability is good thing. > > > >And, following patch makes isolated freepage has new status matched with > >this condition and this check is the obstacle to that change. So remove > >it. > > You could also say that pages from isolated pageblocks can no longer > appear on pcplists after the later patches. Okay. I will do it. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org