From: Peter Zijlstra <peterz@infradead.org>
To: David Miller <davem@davemloft.net>
Cc: ilya.dryomov@inktank.com, mingo@kernel.org, oleg@redhat.com,
torvalds@linux-foundation.org, tglx@linutronix.de,
umgwanakikbuti@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC][PATCH 0/7] nested sleeps, fixes and debug infra
Date: Thu, 7 Aug 2014 10:10:47 +0200 [thread overview]
Message-ID: <20140807081047.GH19379@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140806.141603.1422005306896590750.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]
On Wed, Aug 06, 2014 at 02:16:03PM -0700, David Miller wrote:
> From: Peter Zijlstra <peterz@infradead.org>
> Date: Wed, 6 Aug 2014 10:31:34 +0200
>
> > On Wed, Aug 06, 2014 at 11:51:29AM +0400, Ilya Dryomov wrote:
> >
> >> OK, this one is a bit different.
> >>
> >> WARNING: CPU: 1 PID: 1744 at kernel/sched/core.c:7104 __might_sleep+0x58/0x90()
> >> do not call blocking ops when !TASK_RUNNING; state=1 set at [<ffffffff81070e10>] prepare_to_wait+0x50 /0xa0
> >
> >> [<ffffffff8105bc38>] __might_sleep+0x58/0x90
> >> [<ffffffff8148c671>] lock_sock_nested+0x31/0xb0
> >> [<ffffffff81498aaa>] sk_stream_wait_memory+0x18a/0x2d0
> >
> > Urgh, tedious. Its not an actual bug as is. Due to the condition check
> > in sk_wait_event() we can call lock_sock() with ->state != TASK_RUNNING.
> >
> > I'm not entirely sure what the cleanest way is to make this go away.
> > Possibly something like so:
>
> If you submit this formally to netdev with a signoff I'm willing to apply
> this if it helps the debug infrastructure.
Thanks, for now I'm just collecting things to see how far I can take
this. But I'll certainly include you and netdev on a next posting.
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-08-07 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140804103025.478913141@infradead.org>
2014-08-05 8:33 ` Ilya Dryomov
2014-08-05 13:06 ` Peter Zijlstra
2014-08-06 7:51 ` Ilya Dryomov
2014-08-06 8:31 ` Peter Zijlstra
2014-08-06 21:16 ` David Miller
2014-08-07 8:10 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807081047.GH19379@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=davem@davemloft.net \
--cc=ilya.dryomov@inktank.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox