Re: [PATCH] kexec-export-free_huge_page-to-vmcoreinfo-fix (was: Re: mmotm 2014-07-30-15-57 uploaded)

[Michal Hocko <mhocko@suse.cz>]

On Thu 31-07-14 11:24:52, Michal Hocko wrote:
> On Wed 30-07-14 15:58:50, Andrew Morton wrote:
> > * kexec-export-free_huge_page-to-vmcoreinfo.patch
> 
> This one seems to be missing ifdef for CONFIG_HUGETLBFS

Ohh, David has already posted the fix
http://marc.info/?l=linux-mm&m=140676663218869

> ---
> From bcccb6696b89c700712421858b05dd89ea0d1ec5 Mon Sep 17 00:00:00 2001
> From: Michal Hocko <mhocko@suse.cz>
> Date: Thu, 31 Jul 2014 11:18:57 +0200
> Subject: [PATCH] kexec-export-free_huge_page-to-vmcoreinfo-fix
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> free_huge_page is not defined for !CONFIG_HUGETLBFS. Fix the following
> compilation error:
> 
> kernel/kexec.c: In function a??crash_save_vmcoreinfo_inita??:
> kernel/kexec.c:1628:20: error: a??free_huge_pagea?? undeclared (first use in this function)
>   VMCOREINFO_SYMBOL(free_huge_page);
> 
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
> ---
>  kernel/kexec.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index a3ccf9d7174b..507614acf938 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1625,7 +1625,9 @@ static int __init crash_save_vmcoreinfo_init(void)
>  #endif
>  	VMCOREINFO_NUMBER(PG_head_mask);
>  	VMCOREINFO_NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE);
> +#ifdef CONFIG_HUGETLBFS
>  	VMCOREINFO_SYMBOL(free_huge_page);
> +#endif
>  
>  	arch_crash_save_vmcoreinfo();
>  	update_vmcoreinfo_note();
> -- 
> 2.0.1
> 
> -- 
> Michal Hocko
> SUSE Labs
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>