From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: "Chen, Gong" <gong.chen@linux.intel.com>
Cc: tony.luck@intel.com, bp@alien8.de, linux-acpi@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 1/2] APEI, GHES: Cleanup unnecessary function for lock-less list
Date: Mon, 28 Jul 2014 10:48:55 -0400 [thread overview]
Message-ID: <20140728144855.GC27391@nhori.redhat.com> (raw)
In-Reply-To: <1406530260-26078-2-git-send-email-gong.chen@linux.intel.com>
On Mon, Jul 28, 2014 at 02:50:59AM -0400, Chen, Gong wrote:
> We have provided a reverse function for lock-less list so delete
> uncessary codes.
>
> Signed-off-by: Chen, Gong <gong.chen@linux.intel.com>
> Acked-by: Borislav Petkov <bp@suse.de>
Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> ---
> drivers/acpi/apei/ghes.c | 18 ++----------------
> 1 file changed, 2 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index dab7cb7..1f9fba9 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -734,20 +734,6 @@ static int ghes_notify_sci(struct notifier_block *this,
> return ret;
> }
>
> -static struct llist_node *llist_nodes_reverse(struct llist_node *llnode)
> -{
> - struct llist_node *next, *tail = NULL;
> -
> - while (llnode) {
> - next = llnode->next;
> - llnode->next = tail;
> - tail = llnode;
> - llnode = next;
> - }
> -
> - return tail;
> -}
> -
> static void ghes_proc_in_irq(struct irq_work *irq_work)
> {
> struct llist_node *llnode, *next;
> @@ -761,7 +747,7 @@ static void ghes_proc_in_irq(struct irq_work *irq_work)
> * Because the time order of estatus in list is reversed,
> * revert it back to proper order.
> */
> - llnode = llist_nodes_reverse(llnode);
> + llnode = llist_reverse_order(llnode);
> while (llnode) {
> next = llnode->next;
> estatus_node = llist_entry(llnode, struct ghes_estatus_node,
> @@ -794,7 +780,7 @@ static void ghes_print_queued_estatus(void)
> * Because the time order of estatus in list is reversed,
> * revert it back to proper order.
> */
> - llnode = llist_nodes_reverse(llnode);
> + llnode = llist_reverse_order(llnode);
> while (llnode) {
> estatus_node = llist_entry(llnode, struct ghes_estatus_node,
> llnode);
> --
> 2.0.0.rc2
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-07-28 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 6:50 two minor update patches for RAS Chen, Gong
2014-07-28 6:50 ` [PATCH 1/2] APEI, GHES: Cleanup unnecessary function for lock-less list Chen, Gong
2014-07-28 14:48 ` Naoya Horiguchi [this message]
2014-07-28 6:51 ` [PATCH 2/2] RAS, HWPOISON: Fix wrong error recovery status Chen, Gong
2014-07-29 17:29 ` two minor update patches for RAS Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140728144855.GC27391@nhori.redhat.com \
--to=n-horiguchi@ah.jp.nec.com \
--cc=bp@alien8.de \
--cc=gong.chen@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox