From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by kanga.kvack.org (Postfix) with ESMTP id 8473C6B0035 for ; Fri, 25 Jul 2014 17:38:09 -0400 (EDT) Received: by mail-wg0-f43.google.com with SMTP id l18so4671857wgh.14 for ; Fri, 25 Jul 2014 14:38:08 -0700 (PDT) Received: from theia.8bytes.org (8bytes.org. [2a01:238:4383:600:38bc:a715:4b6d:a889]) by mx.google.com with ESMTP id gv8si5021017wib.98.2014.07.25.14.38.07 for ; Fri, 25 Jul 2014 14:38:07 -0700 (PDT) Date: Fri, 25 Jul 2014 23:38:06 +0200 From: Joerg Roedel Subject: Re: [PATCH 1/3] mmu_notifier: Add mmu_notifier_invalidate_range() Message-ID: <20140725213806.GN14017@8bytes.org> References: <1406212541-25975-1-git-send-email-joro@8bytes.org> <1406212541-25975-2-git-send-email-joro@8bytes.org> <20140725131639.698f18ff@jbarnes-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140725131639.698f18ff@jbarnes-desktop> Sender: owner-linux-mm@kvack.org List-ID: To: Jesse Barnes Cc: Andrew Morton , Andrea Arcangeli , Peter Zijlstra , Rik van Riel , Hugh Dickins , Mel Gorman , Johannes Weiner , Jerome Glisse , jroedel@suse.de, Jay.Cornwall@amd.com, Oded.Gabbay@amd.com, John.Bridgman@amd.com, Suravee.Suthikulpanit@amd.com, ben.sander@amd.com, David Woodhouse , linux-kernel@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org On Fri, Jul 25, 2014 at 01:16:39PM -0700, Jesse Barnes wrote: > > To allow managing external TLBs the MMU-notifiers need to > > catch the moment when pages are unmapped but not yet freed. > > This new notifier catches that moment and notifies the > > interested subsytem when pages that were unmapped are about > > to be freed. The new notifier will only be called between > > invalidate_range_start()/end(). > > So if we were actually sharing page tables, we should be able to make > start/end no-ops and just use this new callback, assuming we didn't > need to do any other serialization or debug stuff, right? Well, not completly. What you need with this patch-set is a invalidate_range and an invalidate_end call-back. There are call sites of the start/end functions where the TLB flush happens after the _end notifier (or at least can wait until _end is called). I did not add invalidate_range calls to these places (yet). But you can easily discard invalidate_range_start, any flush done in there is useless with shared page-tables. I though about removing the need for invalidate_range_end too when writing the patches, and possible solutions are 1) Add mmu_notifier_invalidate_range() to all places where start/end is called too. This might add some unnecessary overhead. 2) Call the invalidate_range() call-back from the mmu_notifier_invalidate_range_end too. 3) Just let the user register the same function for invalidate_range and invalidate_range_end I though that option 1) adds overhead that is not needed (but it might not be too bad, the overhead is an additional iteration over the mmu_notifer list when there are no call-backs registered). Option 2) might also be overhead if a user registers different functions for invalidate_range() and invalidate_range_end(). In the end I came to the conclusion that option 3) is the best one from an overhead POV. But probably targeting better usability with one of the other options is a better choice? I am open for thoughts and suggestions on that. Joerg -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org