From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by kanga.kvack.org (Postfix) with ESMTP id 9999B6B0035 for ; Fri, 18 Jul 2014 03:36:19 -0400 (EDT) Received: by mail-we0-f181.google.com with SMTP id k48so3005756wev.40 for ; Fri, 18 Jul 2014 00:36:19 -0700 (PDT) Received: from mail-wi0-x22f.google.com (mail-wi0-x22f.google.com [2a00:1450:400c:c05::22f]) by mx.google.com with ESMTPS id n17si248711wij.84.2014.07.18.00.36.17 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 18 Jul 2014 00:36:17 -0700 (PDT) Received: by mail-wi0-f175.google.com with SMTP id ho1so358251wib.2 for ; Fri, 18 Jul 2014 00:36:17 -0700 (PDT) Date: Fri, 18 Jul 2014 09:36:14 +0200 From: Michal Hocko Subject: Re: [RFC Patch V1 09/30] mm, memcg: Use cpu_to_mem()/numa_mem_id() to support memoryless node Message-ID: <20140718073614.GC21453@dhcp22.suse.cz> References: <1405064267-11678-1-git-send-email-jiang.liu@linux.intel.com> <1405064267-11678-10-git-send-email-jiang.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1405064267-11678-10-git-send-email-jiang.liu@linux.intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: Jiang Liu Cc: Andrew Morton , Mel Gorman , David Rientjes , Mike Galbraith , Peter Zijlstra , "Rafael J . Wysocki" , Johannes Weiner , Tony Luck , linux-mm@kvack.org, linux-hotplug@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org On Fri 11-07-14 15:37:26, Jiang Liu wrote: > When CONFIG_HAVE_MEMORYLESS_NODES is enabled, cpu_to_node()/numa_node_id() > may return a node without memory, and later cause system failure/panic > when calling kmalloc_node() and friends with returned node id. > So use cpu_to_mem()/numa_mem_id() instead to get the nearest node with > memory for the/current cpu. > > If CONFIG_HAVE_MEMORYLESS_NODES is disabled, cpu_to_mem()/numa_mem_id() > is the same as cpu_to_node()/numa_node_id(). The change makes difference only for really tiny memcgs. If we really have all pages on unevictable list or anon with no swap allowed and that is the reason why no node is set in scan_nodes mask then reclaiming memoryless node or any arbitrary close one doesn't make any difference. The current memcg might not have any memory on that node at all. So the change doesn't make any practical difference and the changelog is misleading. > Signed-off-by: Jiang Liu > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index a2c7bcb0e6eb..d6c4b7255ca9 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1933,7 +1933,7 @@ int mem_cgroup_select_victim_node(struct mem_cgroup *memcg) > * we use curret node. > */ > if (unlikely(node == MAX_NUMNODES)) > - node = numa_node_id(); > + node = numa_mem_id(); > > memcg->last_scanned_node = node; > return node; > -- > 1.7.10.4 > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org