From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f44.google.com (mail-qg0-f44.google.com [209.85.192.44]) by kanga.kvack.org (Postfix) with ESMTP id 0FB696B0083 for ; Wed, 16 Jul 2014 15:58:16 -0400 (EDT) Received: by mail-qg0-f44.google.com with SMTP id e89so1171862qgf.17 for ; Wed, 16 Jul 2014 12:58:15 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id he8si682098qcb.30.2014.07.16.12.58.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jul 2014 12:58:15 -0700 (PDT) Date: Wed, 16 Jul 2014 15:57:45 -0400 From: Naoya Horiguchi Subject: Re: [PATCH 3/3] RAS, HWPOISON: Fix wrong error recovery status Message-ID: <20140716195745.GC8524@nhori.redhat.com> References: <1405478082-30757-1-git-send-email-gong.chen@linux.intel.com> <1405478082-30757-4-git-send-email-gong.chen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1405478082-30757-4-git-send-email-gong.chen@linux.intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: "Chen, Gong" Cc: tony.luck@intel.com, bp@alien8.de, linux-acpi@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org On Tue, Jul 15, 2014 at 10:34:42PM -0400, Chen, Gong wrote: > When Uncorrected error happens, if the poisoned page is referenced > by more than one user after error recovery, the recovery is not > successful. But currently the display result is wrong. > Before this patch: > > MCE 0x44e336: dirty mlocked LRU page recovery: Recovered > MCE 0x44e336: dirty mlocked LRU page still referenced by 1 users > mce: Memory error not recovered > > After this patch: > > MCE 0x44e336: dirty mlocked LRU page recovery: Failed > MCE 0x44e336: dirty mlocked LRU page still referenced by 1 users > mce: Memory error not recovered > > Signed-off-by: Chen, Gong Acked-by: Naoya Horiguchi > --- > mm/memory-failure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index c6399e3..2985861 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -860,7 +860,6 @@ static int page_action(struct page_state *ps, struct page *p, > int count; > > result = ps->action(p, pfn); > - action_result(pfn, ps->msg, result); > > count = page_count(p) - 1; > if (ps->action == me_swapcache_dirty && result == DELAYED) > @@ -871,6 +870,7 @@ static int page_action(struct page_state *ps, struct page *p, > pfn, ps->msg, count); > result = FAILED; > } > + action_result(pfn, ps->msg, result); > > /* Could do more checks here if page looks ok */ > /* > -- > 2.0.0.rc2 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org