From: Andrew Morton <akpm@linux-foundation.org>
To: Oded Gabbay <oded.gabbay@gmail.com>
Cc: "David Airlie" <airlied@linux.ie>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Jerome Glisse" <j.glisse@gmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"John Bridgman" <John.Bridgman@amd.com>,
"Andrew Lewycky" <Andrew.Lewycky@amd.com>,
"Joerg Roedel" <joro@8bytes.org>, linux-mm <linux-mm@kvack.org>,
"Oded Gabbay" <oded.gabbay@amd.com>,
"Naoya Horiguchi" <n-horiguchi@ah.jp.nec.com>,
"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Hugh Dickins" <hughd@google.com>,
"Cyrill Gorcunov" <gorcunov@openvz.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Jianyu Zhan" <nasa4836@gmail.com>
Subject: Re: [PATCH 28/83] mm: Change timing of notification to IOMMUs about a page to be invalidated
Date: Thu, 10 Jul 2014 15:15:51 -0700 [thread overview]
Message-ID: <20140710151551.55646da50617fe9997e2830c@linux-foundation.org> (raw)
In-Reply-To: <1405029208-6703-1-git-send-email-oded.gabbay@amd.com>
On Fri, 11 Jul 2014 00:53:26 +0300 Oded Gabbay <oded.gabbay@gmail.com> wrote:
> From: Andrew Lewycky <Andrew.Lewycky@amd.com>
>
> This patch changes the location of the mmu_notifier_invalidate_page function
> call inside try_to_unmap_one. The mmu_notifier_invalidate_page function
> call tells the IOMMU that a pgae should be invalidated.
>
> The location is changed from after releasing the physical page to
> before releasing the physical page.
>
> This change should prevent the bug that would occur in the
> (rare) case where the GPU attempts to access a page while the CPU
> attempts to swap out that page (or discard it if it is not dirty).
um OK, but what is the effect on all the other
mmu_notifier_ops.invalidate_page() implementations?
Please spell this out in full detail within the changelog and be sure
to cc the affected maintainers.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-07-10 22:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 21:53 Oded Gabbay
2014-07-10 22:15 ` Andrew Morton [this message]
2014-07-10 22:22 ` Joerg Roedel
2014-07-10 22:34 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710151551.55646da50617fe9997e2830c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Andrew.Lewycky@amd.com \
--cc=John.Bridgman@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gorcunov@openvz.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=j.glisse@gmail.com \
--cc=jglisse@redhat.com \
--cc=joro@8bytes.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=nasa4836@gmail.com \
--cc=oded.gabbay@amd.com \
--cc=oded.gabbay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox