From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Vladimir Davydov <vdavydov@parallels.com>
Subject: Re: [PATCH v3 5/9] slab: introduce alien_cache
Date: Wed, 2 Jul 2014 09:48:19 +0900 [thread overview]
Message-ID: <20140702004819.GD9972@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <20140701151547.fa67354878399575c8eb4647@linux-foundation.org>
On Tue, Jul 01, 2014 at 03:15:47PM -0700, Andrew Morton wrote:
> On Tue, 1 Jul 2014 17:27:34 +0900 Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
>
> > -static struct array_cache **alloc_alien_cache(int node, int limit, gfp_t gfp)
> > +static struct alien_cache *__alloc_alien_cache(int node, int entries,
> > + int batch, gfp_t gfp)
> > +{
> > + int memsize = sizeof(void *) * entries + sizeof(struct alien_cache);
>
> nit: all five memsizes in slab.c have type `int'. size_t would be more
> appropriate.
>
Hello,
As my inspection, there are 4 memsize. Can you confirm that?
Anyway, here goes the patch you suggested.
Thanks.
----------8<-----------------
next prev parent reply other threads:[~2014-07-02 0:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 8:27 [PATCH v3 0/9] clean-up and remove lockdep annotation in SLAB Joonsoo Kim
2014-07-01 8:27 ` [PATCH v3 1/9] slab: add unlikely macro to help compiler Joonsoo Kim
2014-07-01 8:27 ` [PATCH v3 2/9] slab: move up code to get kmem_cache_node in free_block() Joonsoo Kim
2014-07-01 22:21 ` David Rientjes
2014-07-02 0:39 ` Joonsoo Kim
2014-07-01 8:27 ` [PATCH v3 3/9] slab: defer slab_destroy " Joonsoo Kim
2014-07-01 22:25 ` David Rientjes
2014-07-02 0:44 ` Joonsoo Kim
2014-07-01 8:27 ` [PATCH v3 4/9] slab: factor out initialization of arracy cache Joonsoo Kim
2014-07-01 22:26 ` David Rientjes
2014-07-02 0:46 ` Joonsoo Kim
2014-07-01 8:27 ` [PATCH v3 5/9] slab: introduce alien_cache Joonsoo Kim
2014-07-01 22:15 ` Andrew Morton
2014-07-02 0:48 ` Joonsoo Kim [this message]
2014-07-01 8:27 ` [PATCH v3 6/9] slab: use the lock on alien_cache, instead of the lock on array_cache Joonsoo Kim
2014-07-01 8:27 ` [PATCH v3 7/9] slab: destroy a slab without holding any alien cache lock Joonsoo Kim
2014-07-01 8:27 ` [PATCH v3 8/9] slab: remove a useless lockdep annotation Joonsoo Kim
2014-07-01 8:27 ` [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702004819.GD9972@js1304-P5Q-DELUXE \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox