linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.cz>
To: Richard Weinberger <richard@nod.at>
Cc: hannes@cmpxchg.org, bsingharora@gmail.com,
	kamezawa.hiroyu@jp.fujitsu.com, akpm@linux-foundation.org,
	vdavydov@parallels.com, tj@kernel.org, handai.szj@taobao.com,
	rientjes@google.com, oleg@redhat.com, rusty@rustcorp.com.au,
	kirill.shutemov@linux.intel.com, linux-kernel@vger.kernel.org,
	cgroups@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC][PATCH] oom: Be less verbose if the oom_control event fd has listeners
Date: Thu, 5 Jun 2014 17:00:26 +0200	[thread overview]
Message-ID: <20140605150025.GB15939@dhcp22.suse.cz> (raw)
In-Reply-To: <1401976841-3899-2-git-send-email-richard@nod.at>

On Thu 05-06-14 16:00:41, Richard Weinberger wrote:
> Don't spam the kernel logs if the oom_control event fd has listeners.
> In this case there is no need to print that much lines as user space
> will anyway notice that the memory cgroup has reached its limit.

But how do you debug why it is reaching the limit and why a particular
process has been killed?

If we are printing too much then OK, let's remove those parts which are
not that useful but hiding information which tells us more about the oom
decision doesn't sound right to me.

> Signed-off-by: Richard Weinberger <richard@nod.at>
[...]
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2014-06-05 15:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 14:00 oom: Be less verbose Richard Weinberger
2014-06-05 14:00 ` [RFC][PATCH] oom: Be less verbose if the oom_control event fd has listeners Richard Weinberger
2014-06-05 14:18   ` Oleg Nesterov
2014-06-05 15:46     ` Richard Weinberger
2014-06-05 16:00       ` Oleg Nesterov
2014-06-05 16:10         ` Richard Weinberger
2014-06-05 15:00   ` Michal Hocko [this message]
2014-06-05 15:55     ` Richard Weinberger
2014-06-05 16:18       ` Michal Hocko
2014-06-05 21:58         ` Richard Weinberger
2014-06-05 21:01     ` David Rientjes
2014-06-06  9:10       ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140605150025.GB15939@dhcp22.suse.cz \
    --to=mhocko@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=bsingharora@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=handai.szj@taobao.com \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=oleg@redhat.com \
    --cc=richard@nod.at \
    --cc=rientjes@google.com \
    --cc=rusty@rustcorp.com.au \
    --cc=tj@kernel.org \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox