From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com [209.85.192.172]) by kanga.kvack.org (Postfix) with ESMTP id 60EA96B0092 for ; Mon, 2 Jun 2014 18:44:34 -0400 (EDT) Received: by mail-pd0-f172.google.com with SMTP id fp1so3866949pdb.17 for ; Mon, 02 Jun 2014 15:44:34 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTP id cv17si17833150pac.7.2014.06.02.15.44.33 for ; Mon, 02 Jun 2014 15:44:33 -0700 (PDT) Date: Mon, 2 Jun 2014 15:44:31 -0700 From: Andrew Morton Subject: Re: [PATCH 1/3] memory-failure: Send right signal code to correct thread Message-Id: <20140602154431.2d77c066546354b9bd81e60b@linux-foundation.org> In-Reply-To: <1401432670-24664-2-git-send-email-n-horiguchi@ah.jp.nec.com> References: <53877e9c.8b2cdc0a.1604.ffffea43SMTPIN_ADDED_BROKEN@mx.google.com> <1401432670-24664-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1401432670-24664-2-git-send-email-n-horiguchi@ah.jp.nec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Naoya Horiguchi Cc: Tony Luck , Andi Kleen , Kamil Iskra , Borislav Petkov , Chen Gong , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Fri, 30 May 2014 02:51:08 -0400 Naoya Horiguchi wrote: > From: Tony Luck > > When a thread in a multi-threaded application hits a machine > check because of an uncorrectable error in memory - we want to > send the SIGBUS with si.si_code = BUS_MCEERR_AR to that thread. > Currently we fail to do that if the active thread is not the > primary thread in the process. collect_procs() just finds primary > threads and this test: > if ((flags & MF_ACTION_REQUIRED) && t == current) { > will see that the thread we found isn't the current thread > and so send a si.si_code = BUS_MCEERR_AO to the primary > (and nothing to the active thread at this time). > > We can fix this by checking whether "current" shares the same > mm with the process that collect_procs() said owned the page. > If so, we send the SIGBUS to current (with code BUS_MCEERR_AR). > > Reported-by: Otto Bruggeman > Signed-off-by: Tony Luck > Cc: Andi Kleen > Cc: Borislav Petkov > Cc: Chen Gong > Acked-by: Naoya Horiguchi You were on the patch delivery path, so it should have included your signed-off-by. Documentation/SubmittingPatches section 12 has the details. I have made that change to my copies of patches 1 and 2. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org