From: Johannes Weiner <hannes@cmpxchg.org>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: akpm@linux-foundation.org, mhocko@suse.cz, riel@redhat.com,
kosaki.motohiro@jp.fujitsu.com, cldu@marvell.com,
handai.szj@taobao.com, paul.gortmaker@windriver.com,
mpatlasov@parallels.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page-writeback.c: remove outdated comment
Date: Mon, 2 Jun 2014 10:29:00 -0400 [thread overview]
Message-ID: <20140602142900.GN2878@cmpxchg.org> (raw)
In-Reply-To: <1401702440-1884-1-git-send-email-nasa4836@gmail.com>
On Mon, Jun 02, 2014 at 05:47:20PM +0800, Jianyu Zhan wrote:
> There is an orphaned prehistoric comment , which used to be against
> get_dirty_limits(), the dawn of global_dirtyable_memory().
>
> Back then, the implementation of get_dirty_limits() is complicated and
> full of magic numbers, so this comment is necessary. But we now
> use the clear and neat global_dirtyable_memory(), which renders this
> comment ambiguous and useless. Remove it.
>
> Signed-off-by: Jianyu Zhan <nasa4836@gmail.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-06-02 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 9:47 Jianyu Zhan
2014-06-02 14:29 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602142900.GN2878@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=cldu@marvell.com \
--cc=handai.szj@taobao.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=mpatlasov@parallels.com \
--cc=nasa4836@gmail.com \
--cc=paul.gortmaker@windriver.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox