From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by kanga.kvack.org (Postfix) with ESMTP id B5B046B0035 for ; Thu, 29 May 2014 02:34:45 -0400 (EDT) Received: by mail-pa0-f42.google.com with SMTP id rd3so12435278pab.1 for ; Wed, 28 May 2014 23:34:45 -0700 (PDT) Received: from lgeamrelo01.lge.com (lgeamrelo01.lge.com. [156.147.1.125]) by mx.google.com with ESMTP id qq2si26612760pbb.105.2014.05.28.23.34.43 for ; Wed, 28 May 2014 23:34:44 -0700 (PDT) Date: Thu, 29 May 2014 15:35:05 +0900 From: Minchan Kim Subject: Re: [PATCH] CMA: use MIGRATE_SYNC in alloc_contig_range() Message-ID: <20140529063505.GH10092@bbox> References: <1401344750-3684-1-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1401344750-3684-1-git-send-email-iamjoonsoo.kim@lge.com> Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: Andrew Morton , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Marek Szyprowski , Michal Nazarewicz , "Aneesh Kumar K.V" On Thu, May 29, 2014 at 03:25:50PM +0900, Joonsoo Kim wrote: > Before commit 'mm, compaction: embed migration mode in compact_control' > from David is merged, alloc_contig_range() used sync migration, > instead of sync_light migration. This doesn't break anything currently > because page isolation doesn't have any difference with sync and > sync_light, but it could in the future, so change back as it was. > > And pass cc->mode to migrate_pages(), instead of passing MIGRATE_SYNC > to migrate_pages(). > > Signed-off-by: Joonsoo Kim Acked-by: Minchan Kim Hello Joonsoo, Please Ccing me if you send patch related to CMA mm part. I have reviewed/fixed mm part of CMA for a long time so worth to Cced although I always don't have a time to look at it. :) Thanks. > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 7f97767..97c4185 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6262,7 +6262,7 @@ static int __alloc_contig_migrate_range(struct compact_control *cc, > cc->nr_migratepages -= nr_reclaimed; > > ret = migrate_pages(&cc->migratepages, alloc_migrate_target, > - NULL, 0, MIGRATE_SYNC, MR_CMA); > + NULL, 0, cc->mode, MR_CMA); > } > if (ret < 0) { > putback_movable_pages(&cc->migratepages); > @@ -6301,7 +6301,7 @@ int alloc_contig_range(unsigned long start, unsigned long end, > .nr_migratepages = 0, > .order = -1, > .zone = page_zone(pfn_to_page(start)), > - .mode = MIGRATE_SYNC_LIGHT, > + .mode = MIGRATE_SYNC, > .ignore_skip_hint = true, > }; > INIT_LIST_HEAD(&cc.migratepages); > -- > 1.7.9.5 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org