From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43])
	by kanga.kvack.org (Postfix) with ESMTP id AA90B6B0037
	for <linux-mm@kvack.org>; Wed, 21 May 2014 20:08:00 -0400 (EDT)
Received: by mail-ee0-f43.google.com with SMTP id d17so2045976eek.16
        for <linux-mm@kvack.org>; Wed, 21 May 2014 17:08:00 -0700 (PDT)
Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15])
        by mx.google.com with ESMTPS id b7si11813943eeh.163.2014.05.21.17.07.59
        for <linux-mm@kvack.org>
        (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Wed, 21 May 2014 17:07:59 -0700 (PDT)
Date: Thu, 22 May 2014 01:07:56 +0100
From: Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] mm: non-atomically mark page accessed during page cache
 allocation where possible -fix
Message-ID: <20140522000755.GB23991@suse.de>
References: <1399974350-11089-1-git-send-email-mgorman@suse.de>
 <1399974350-11089-19-git-send-email-mgorman@suse.de>
 <20140520154900.GO23991@suse.de>
 <20140520123453.09a76dd0c8fad40082a16289@linux-foundation.org>
 <20140521120916.GS23991@suse.de>
 <20140521151142.9d084dd64251bce4c44c214d@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <20140521151142.9d084dd64251bce4c44c214d@linux-foundation.org>
Sender: owner-linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>, Vlastimil Babka <vbabka@suse.cz>, Jan Kara <jack@suse.cz>, Michal Hocko <mhocko@suse.cz>, Hugh Dickins <hughd@google.com>, Peter Zijlstra <peterz@infradead.org>, Dave Hansen <dave.hansen@intel.com>, Linux Kernel <linux-kernel@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>, Linux-FSDevel <linux-fsdevel@vger.kernel.org>, Prabhakar Lad <prabhakar.csengg@gmail.com>

On Wed, May 21, 2014 at 03:11:42PM -0700, Andrew Morton wrote:
> On Wed, 21 May 2014 13:09:16 +0100 Mel Gorman <mgorman@suse.de> wrote:
> 
> > > From: Andrew Morton <akpm@linux-foundation.org>
> > > Subject: mm/shmem.c: don't run init_page_accessed() against an uninitialised pointer
> > > 
> > > If shmem_getpage() returned an error then it didn't necessarily initialise
> > > *pagep.  So shmem_write_begin() shouldn't be playing with *pagep in this
> > > situation.
> > > 
> > > Fixes an oops when "mm: non-atomically mark page accessed during page
> > > cache allocation where possible" (quite reasonably) left *pagep
> > > uninitialized.
> > > 
> > > Reported-by: Prabhakar Lad <prabhakar.csengg@gmail.com>
> > > Cc: Johannes Weiner <hannes@cmpxchg.org>
> > > Cc: Vlastimil Babka <vbabka@suse.cz>
> > > Cc: Jan Kara <jack@suse.cz>
> > > Cc: Michal Hocko <mhocko@suse.cz>
> > > Cc: Hugh Dickins <hughd@google.com>
> > > Cc: Peter Zijlstra <peterz@infradead.org>
> > > Cc: Dave Hansen <dave.hansen@intel.com>
> > > Cc: Mel Gorman <mgorman@suse.de>
> > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > 
> > Acked-by: Mel Gorman <mgorman@suse.de>
> 
> What to do with
> http://ozlabs.org/~akpm/mmots/broken-out/mm-non-atomically-mark-page-accessed-during-page-cache-allocation-where-possible-fix.patch?
> 
> We shouldn't need it any more.  otoh it's pretty harmless.  otooh it
> will hide bugs such as this one.
> 

Drop it.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>