From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by kanga.kvack.org (Postfix) with ESMTP id 2FA7C6B0038 for ; Mon, 19 May 2014 19:43:04 -0400 (EDT) Received: by mail-pa0-f54.google.com with SMTP id bj1so6523962pad.27 for ; Mon, 19 May 2014 16:43:03 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTP id vx5si21505845pab.104.2014.05.19.16.43.03 for ; Mon, 19 May 2014 16:43:03 -0700 (PDT) Date: Mon, 19 May 2014 16:43:01 -0700 From: Andrew Morton Subject: Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Message-Id: <20140519164301.eafd3dd288ccb88361ddcfc7@linux-foundation.org> In-Reply-To: References: <1399541296-18810-1-git-send-email-maddy@linux.vnet.ibm.com> <537479E7.90806@linux.vnet.ibm.com> <87wqdik4n5.fsf@rustcorp.com.au> <53797511.1050409@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Hugh Dickins Cc: Madhavan Srinivasan , Rusty Russell , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org, dave.hansen@intel.com On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins wrote: > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be > the order of the fault-around size in bytes, and fault_around_pages() > use 1UL << (fault_around_order - PAGE_SHIFT) Yes. And shame on me for missing it (this time!) at review. There's still time to fix this. Patches, please. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org