From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f49.google.com (mail-qg0-f49.google.com [209.85.192.49]) by kanga.kvack.org (Postfix) with ESMTP id 87E1D6B0035 for ; Tue, 13 May 2014 12:45:58 -0400 (EDT) Received: by mail-qg0-f49.google.com with SMTP id a108so721343qge.22 for ; Tue, 13 May 2014 09:45:58 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id 100si8105346qgf.187.2014.05.13.09.45.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 May 2014 09:45:56 -0700 (PDT) Date: Tue, 13 May 2014 18:45:52 +0200 From: Peter Zijlstra Subject: Re: [PATCH] SCHED: remove proliferation of wait_on_bit action functions. Message-ID: <20140513164552.GA5226@laptop.programming.kicks-ass.net> References: <20140501123738.3e64b2d2@notabene.brown> <30769.1399997170@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <30769.1399997170@warthog.procyon.org.uk> Sender: owner-linux-mm@kvack.org List-ID: To: David Howells Cc: NeilBrown , Oleg Nesterov , Steven Whitehouse , dm-devel@redhat.com, Chris Mason , Josef Bacik , Steve French , Theodore Ts'o , Trond Myklebust , Ingo Molnar , Andrew Morton , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org On Tue, May 13, 2014 at 05:06:10PM +0100, David Howells wrote: > NeilBrown wrote: >=20 > > The wait_on_bit() call in __fscache_wait_on_invalidate() was ambiguous > > as it specified TASK_UNINTERRUPTIBLE but used > > fscache_wait_bit_interruptible as an action function. > > As any error return is never checked I assumed that 'uninterruptible' > > was correct. >=20 > Bug. It should be uninterruptible in both places. Thanks David, queued the patch! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org