From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Vlastimil Babka <vbabka@suse.cz>,
Sasha Levin <sasha.levin@oracle.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Mel Gorman <mgorman@suse.de>, Yong-Taek Lee <ytk.lee@samsung.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>,
Michal Nazarewicz <mina86@mina86.com>,
Dave Jones <davej@redhat.com>
Subject: Re: [PATCH 2/2] mm/page_alloc: DEBUG_VM checks for free_list placement of CMA and RESERVE pages
Date: Thu, 8 May 2014 15:34:33 -0700 [thread overview]
Message-ID: <20140508153433.7fcbe624549259b68659fe10@linux-foundation.org> (raw)
In-Reply-To: <20140508061937.GE5282@bbox>
On Thu, 8 May 2014 15:19:37 +0900 Minchan Kim <minchan@kernel.org> wrote:
> > I also think that VM_DEBUG overhead isn't problem because of same
> > reason from Vlastimil.
>
> Guys, please read this.
>
> https://lkml.org/lkml/2013/7/17/591
>
> If you guys really want it, we could separate it with
> CONFIG_DEBUG_CMA or CONFIG_DEBUG_RESERVE like stuff.
> Otherwise, just remain in mmotm.
Wise words, those.
Yes, these checks are in a pretty hot path. I'm inclined to make the
patch -mm (and -next) only.
Unless there's a really good reason, such as "nobody who uses CMA is
likely to be testing -next", which sounds likely :(
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-05-08 22:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 17:35 [PATCH v3] mm/page_alloc: fix freeing of MIGRATE_RESERVE migratetype pages Bartlomiej Zolnierkiewicz
2014-03-21 14:16 ` Vlastimil Babka
2014-03-25 13:47 ` Bartlomiej Zolnierkiewicz
2014-04-03 15:36 ` Vlastimil Babka
2014-04-03 15:40 ` [PATCH 1/2] mm/page_alloc: prevent MIGRATE_RESERVE pages from being misplaced Vlastimil Babka
2014-04-03 15:40 ` [PATCH 2/2] mm/page_alloc: DEBUG_VM checks for free_list placement of CMA and RESERVE pages Vlastimil Babka
2014-04-16 1:09 ` Joonsoo Kim
2014-04-30 21:46 ` Sasha Levin
2014-05-02 12:08 ` Vlastimil Babka
2014-05-05 14:36 ` Sasha Levin
2014-05-05 15:50 ` Vlastimil Babka
2014-05-05 16:37 ` Sasha Levin
2014-05-07 1:33 ` Minchan Kim
2014-05-07 14:59 ` Vlastimil Babka
2014-05-08 5:54 ` Joonsoo Kim
2014-05-08 6:19 ` Minchan Kim
2014-05-08 22:34 ` Andrew Morton [this message]
2014-05-13 1:40 ` Joonsoo Kim
2014-05-08 8:51 ` Mel Gorman
2014-05-12 8:28 ` Vlastimil Babka
2014-05-13 1:37 ` Joonsoo Kim
2014-05-14 3:47 ` Sasha Levin
2014-05-14 5:19 ` Hugh Dickins
2014-05-14 9:01 ` Vlastimil Babka
2014-04-16 0:56 ` [PATCH 1/2] mm/page_alloc: prevent MIGRATE_RESERVE pages from being misplaced Joonsoo Kim
2014-04-17 23:29 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508153433.7fcbe624549259b68659fe10@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=davej@redhat.com \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
--cc=ytk.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox