From: Michal Hocko <mhocko@suse.cz>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH -mm 2/2] memcg: cleanup kmem cache creation/destruction functions naming
Date: Wed, 7 May 2014 14:45:33 +0200 [thread overview]
Message-ID: <20140507124533.GF9489@dhcp22.suse.cz> (raw)
In-Reply-To: <c3bef5d3667668f89a4acabda64eb79d730037ec.1399450112.git.vdavydov@parallels.com>
On Wed 07-05-14 12:15:30, Vladimir Davydov wrote:
> Current names are rather inconsistent. Let's try to improve them.
Yes the old names are a giant mess. I am not sure the new ones are
that much better however.
> Brief change log:
>
> ** old name ** ** new name **
>
> kmem_cache_create_memcg kmem_cache_request_memcg_copy
Both are bad because the first suggests we are creating memcg and the second that
we are requesting a copy of memcg.
memcg_alloc_kmem_cache?
_copy suffix is a bit confusing. E.g. copy_mm and others either to
shallow or deep copy depending on the context. This one always creats a
deep copy. Also why it is imporatant to treat the created caches as
copies?
> memcg_kmem_create_cache memcg_copy_kmem_cache
memcg_register_kmem_cache? It also allocates so this name is a bit
awkward as well.
> memcg_kmem_destroy_cache memcg_destroy_kmem_cache_copy
memcg_unregister_kmem_cache to match the above?
> __kmem_cache_destroy_memcg_children __kmem_cache_destroy_memcg_copies
> kmem_cache_destroy_memcg_children kmem_cache_destroy_memcg_copies
_children suffix is really confusing because they have different meaning in
memcg and refer to children groups.
memcg_cleanup_kmem_chache_memcg_params? It doesn't have to live in the
kmem_cache namespace because it only does only memcg kmem specific
stuff.
> mem_cgroup_destroy_all_caches memcg_destroy_kmem_cache_copies
>
> create_work memcg_kmem_cache_copy_work
memcg_register_cache_work?
> memcg_create_cache_work_func memcg_kmem_cache_copy_work_func
memcg_register_cache_func?
> memcg_create_cache_enqueue memcg_schedule_kmem_cache_copy
memcg_schedule_register_cache?
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-05-07 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 8:15 [PATCH -mm 1/2] memcg: get rid of memcg_create_cache_name Vladimir Davydov
2014-05-07 8:15 ` [PATCH -mm 2/2] memcg: cleanup kmem cache creation/destruction functions naming Vladimir Davydov
2014-05-07 12:45 ` Michal Hocko [this message]
2014-05-13 15:05 ` [PATCH -mm v2] " Vladimir Davydov
2014-05-14 9:40 ` Michal Hocko
2014-05-07 9:51 ` [PATCH -mm 1/2] memcg: get rid of memcg_create_cache_name Michal Hocko
2014-05-07 10:45 ` Vladimir Davydov
2014-05-07 11:19 ` Michal Hocko
2014-05-07 20:53 ` Andrew Morton
2014-05-08 7:08 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140507124533.GF9489@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox