From: Andrew Morton <akpm@linux-foundation.org>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
torvalds@linux-foundation.org, mgorman@suse.de, hpa@zytor.com,
mingo@kernel.org, steven@uplinklabs.net, riel@redhat.com,
david.vrabel@citrix.com, peterz@infradead.org,
xemul@parallels.com
Subject: Re: [patch 2/2] mm: pgtable -- Require X86_64 for soft-dirty tracker
Date: Mon, 5 May 2014 16:31:23 -0700 [thread overview]
Message-ID: <20140505163123.65e6f8853cdf0646f26bd5b4@linux-foundation.org> (raw)
In-Reply-To: <20140425082042.848656782@openvz.org>
On Fri, 25 Apr 2014 12:10:32 +0400 Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> Tracking dirty status on 2 level pages requires very ugly macros
> and taking into account how old the machines who can operate
> without PAE mode only are, lets drop soft dirty tracker from
> them for code simplicity (note I can't drop all the macros
> from 2 level pages by now since _PAGE_BIT_PROTNONE and
> _PAGE_BIT_FILE are still used even without tracker).
>
> Linus proposed to completely rip off softdirty support on
> x86-32 (even with PAE) and since for CRIU we're not planning
> to support native x86-32 mode, lets do that.
>
> (Softdirty tracker is relatively new feature which mostly used
> by CRIU so I don't expect if such API change would cause problems
> on userspace).
i386 allnoconfig:
In file included from /usr/src/25/arch/x86/include/asm/pgtable.h:886,
from include/linux/mm.h:51,
from include/linux/suspend.h:8,
from arch/x86/kernel/asm-offsets.c:12:
include/asm-generic/pgtable.h:414: error: redefinition of 'pte_soft_dirty'
/usr/src/25/arch/x86/include/asm/pgtable.h:300: note: previous definition of 'pte_soft_dirty' was here
include/asm-generic/pgtable.h:419: error: redefinition of 'pmd_soft_dirty'
/usr/src/25/arch/x86/include/asm/pgtable.h:305: note: previous definition of 'pmd_soft_dirty' was here
include/asm-generic/pgtable.h:424: error: redefinition of 'pte_mksoft_dirty'
/usr/src/25/arch/x86/include/asm/pgtable.h:310: note: previous definition of 'pte_mksoft_dirty' was here
include/asm-generic/pgtable.h:429: error: redefinition of 'pmd_mksoft_dirty'
/usr/src/25/arch/x86/include/asm/pgtable.h:315: note: previous definition of 'pmd_mksoft_dirty' was here
include/asm-generic/pgtable.h:434: error: redefinition of 'pte_swp_mksoft_dirty'
/usr/src/25/arch/x86/include/asm/pgtable.h:868: note: previous definition of 'pte_swp_mksoft_dirty' was here
include/asm-generic/pgtable.h:439: error: redefinition of 'pte_swp_soft_dirty'
/usr/src/25/arch/x86/include/asm/pgtable.h:874: note: previous definition of 'pte_swp_soft_dirty' was here
include/asm-generic/pgtable.h:444: error: redefinition of 'pte_swp_clear_soft_dirty'
/usr/src/25/arch/x86/include/asm/pgtable.h:880: note: previous definition of 'pte_swp_clear_soft_dirty' was here
include/asm-generic/pgtable.h:449: error: redefinition of 'pte_file_clear_soft_dirty'
/usr/src/25/arch/x86/include/asm/pgtable.h:320: note: previous definition of 'pte_file_clear_soft_dirty' was here
include/asm-generic/pgtable.h:454: error: redefinition of 'pte_file_mksoft_dirty'
/usr/src/25/arch/x86/include/asm/pgtable.h:325: note: previous definition of 'pte_file_mksoft_dirty' was here
include/asm-generic/pgtable.h:459: error: redefinition of 'pte_file_soft_dirty'
/usr/src/25/arch/x86/include/asm/pgtable.h:330: note: previous definition of 'pte_file_soft_dirty' was here
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-05-05 23:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 8:10 [patch 0/2] A few simplifications for softdirty memory tracker code Cyrill Gorcunov
2014-04-25 8:10 ` [patch 1/2] mm: pgtable -- Drop unneeded preprocessor ifdef Cyrill Gorcunov
2014-04-25 8:10 ` [patch 2/2] mm: pgtable -- Require X86_64 for soft-dirty tracker Cyrill Gorcunov
2014-05-05 23:31 ` Andrew Morton [this message]
2014-05-06 8:25 ` [patch 2/2] mm: pgtable -- Require X86_64 for soft-dirty tracker, v2 Cyrill Gorcunov
2014-05-06 16:28 ` [patch 2/2] mm: pgtable -- Require X86_64 for soft-dirty tracker H. Peter Anvin
2014-05-06 17:03 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505163123.65e6f8853cdf0646f26bd5b4@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david.vrabel@citrix.com \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=steven@uplinklabs.net \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox