From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by kanga.kvack.org (Postfix) with ESMTP id B6F3A6B0036 for ; Fri, 2 May 2014 11:48:55 -0400 (EDT) Received: by mail-ee0-f49.google.com with SMTP id e53so3259274eek.36 for ; Fri, 02 May 2014 08:48:55 -0700 (PDT) Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id f45si2031471eet.9.2014.05.02.08.48.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 02 May 2014 08:48:54 -0700 (PDT) Date: Fri, 2 May 2014 17:48:52 +0200 From: Michal Hocko Subject: Re: [PATCH 1/4] memcg, mm: introduce lowlimit reclaim Message-ID: <20140502154852.GO3446@dhcp22.suse.cz> References: <1398688005-26207-1-git-send-email-mhocko@suse.cz> <1398688005-26207-2-git-send-email-mhocko@suse.cz> <20140430225550.GD26041@cmpxchg.org> <20140502093628.GC3446@dhcp22.suse.cz> <20140502120715.GI3446@dhcp22.suse.cz> <20140502130118.GK23420@cmpxchg.org> <20140502141515.GJ3446@dhcp22.suse.cz> <20140502150434.GM23420@cmpxchg.org> <20140502151120.GN3446@dhcp22.suse.cz> <20140502153451.GN23420@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140502153451.GN23420@cmpxchg.org> Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Andrew Morton , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Greg Thelen , Michel Lespinasse , Tejun Heo , Hugh Dickins , Roman Gushchin , LKML , linux-mm@kvack.org On Fri 02-05-14 11:34:51, Johannes Weiner wrote: > On Fri, May 02, 2014 at 05:11:20PM +0200, Michal Hocko wrote: > > On Fri 02-05-14 11:04:34, Johannes Weiner wrote: > > [...] > > > > @@ -2236,12 +2246,9 @@ static unsigned __shrink_zone(struct zone *zone, struct scan_control *sc, > > > > do { > > > > struct lruvec *lruvec; > > > > > > > > - /* > > > > - * Memcg might be under its low limit so we have to > > > > - * skip it during the first reclaim round > > > > - */ > > > > - if (follow_low_limit && > > > > - !mem_cgroup_reclaim_eligible(memcg, root)) { > > > > + /* Memcg might be protected from the reclaim */ > > > > + if (force_memcg_guarantee && > > > > > > respect_? consider_? > > > > enforce_ ? > > A native speaker might be better at this, but to me it seems weird to > enforce a promise. honor_memcg_guarantee? OK, will go with honor. Thanks! ---