From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qa0-f44.google.com (mail-qa0-f44.google.com [209.85.216.44]) by kanga.kvack.org (Postfix) with ESMTP id 63BFF6B003C for ; Thu, 1 May 2014 05:31:45 -0400 (EDT) Received: by mail-qa0-f44.google.com with SMTP id k15so2800107qaq.3 for ; Thu, 01 May 2014 02:31:45 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id d5si12373033qad.201.2014.05.01.02.31.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 May 2014 02:31:44 -0700 (PDT) Date: Thu, 1 May 2014 11:31:40 +0200 From: Peter Zijlstra Subject: Re: [PATCH] SCHED: remove proliferation of wait_on_bit action functions. Message-ID: <20140501093140.GN11096@twins.programming.kicks-ass.net> References: <20140501123738.3e64b2d2@notabene.brown> <20140501074257.GK11096@twins.programming.kicks-ass.net> <20140501192605.6b5383f8@notabene.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140501192605.6b5383f8@notabene.brown> Sender: owner-linux-mm@kvack.org List-ID: To: NeilBrown Cc: Oleg Nesterov , David Howells , Steven Whitehouse , dm-devel@redhat.com, Chris Mason , Josef Bacik , Steve French , Theodore Ts'o , Trond Myklebust , Ingo Molnar , Roland McGrath , Andrew Morton , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org On Thu, May 01, 2014 at 07:26:05PM +1000, NeilBrown wrote: > On Thu, 1 May 2014 09:42:57 +0200 Peter Zijlstra wrote: > > > On Thu, May 01, 2014 at 12:37:38PM +1000, NeilBrown wrote: > > > +static inline int > > > +wait_on_bit(void *word, int bit, unsigned mode) > > > +{ > > > + if (!test_bit(bit, word)) > > > + return 0; > > > + return out_of_line_wait_on_bit(word, bit, > > > + bit_wait, > > > + mode & 65535); > > > +} > > > > Still puzzled by the 16 bit mask there ;-) > > I clearly remember removing that! > And I've just done it again. > I hope it doesn't re-reappear! > :-) > NeilBrown Seems dead now, I'll hold out for a little while so that dhowells can explain this fscache thing. Then I'll queue it. Ingo is currently enjoying a long weekend and is fighting (well I am now) a stability issue in -tip kernels, so it might be a little while before it actually shows up in the git tree. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org