linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave@sr71.net>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, x86@kernel.org, Dave Hansen <dave@sr71.net>
Subject: [PATCH 4/8] x86: mm: unify remote invlpg code
Date: Fri, 25 Apr 2014 15:37:47 -0700	[thread overview]
Message-ID: <20140425223747.5D6B4D6E@viggo.jf.intel.com> (raw)
In-Reply-To: <20140425223742.0A27E42E@viggo.jf.intel.com>


From: Dave Hansen <dave.hansen@linux.intel.com>

There are currently three paths through the remote flush code:

1. full invalidation
2. single page invalidation using invlpg
3. ranged invalidation using invlpg

This takes 2 and 3 and combines them in to a single path by
making the single-page one just be the start and end be start
plus a single page.  This makes placement of our tracepoint easier.

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Mel Gorman <mgorman@suse.de>
---

 b/arch/x86/mm/tlb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -puN arch/x86/mm/tlb.c~x86-tlb-simplify-remote-flush-code arch/x86/mm/tlb.c
--- a/arch/x86/mm/tlb.c~x86-tlb-simplify-remote-flush-code	2014-04-25 15:33:13.091058396 -0700
+++ b/arch/x86/mm/tlb.c	2014-04-25 15:33:13.094058531 -0700
@@ -102,13 +102,13 @@ static void flush_tlb_func(void *info)
 
 	if (f->flush_mm != this_cpu_read(cpu_tlbstate.active_mm))
 		return;
+	if (!f->flush_end)
+		f->flush_end = f->flush_start + PAGE_SIZE;
 
 	count_vm_tlb_event(NR_TLB_REMOTE_FLUSH_RECEIVED);
 	if (this_cpu_read(cpu_tlbstate.state) == TLBSTATE_OK) {
 		if (f->flush_end == TLB_FLUSH_ALL)
 			local_flush_tlb();
-		else if (!f->flush_end)
-			__flush_tlb_single(f->flush_start);
 		else {
 			unsigned long addr;
 			addr = f->flush_start;
_

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2014-04-25 22:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25 22:37 [PATCH 0/8] [v4] x86: rework tlb range flushing code Dave Hansen
2014-04-25 22:37 ` [PATCH 1/8] x86: mm: clean up tlb " Dave Hansen
2014-04-25 22:37 ` [PATCH 2/8] x86: mm: rip out complicated, out-of-date, buggy TLB flushing Dave Hansen
2014-04-25 22:37 ` [PATCH 3/8] x86: mm: fix missed global TLB flush stat Dave Hansen
2014-04-25 22:37 ` Dave Hansen [this message]
2014-04-25 22:37 ` [PATCH 5/8] x86: mm: add tracepoints for TLB flushes Dave Hansen
2014-04-25 22:37 ` [PATCH 6/8] x86: mm: new tunable for single vs full TLB flush Dave Hansen
2014-04-25 22:37 ` [PATCH 7/8] x86: mm: set TLB flush tunable to sane value (33) Dave Hansen
2014-04-25 22:37 ` [PATCH 8/8] x86: mm: instrument flush times Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140425223747.5D6B4D6E@viggo.jf.intel.com \
    --to=dave@sr71.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox