linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Dave Jones <davej@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: sched: long running interrupts breaking spinlocks
Date: Tue, 8 Apr 2014 18:10:23 +0200	[thread overview]
Message-ID: <20140408161023.GP10526@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <53441540.7070102@oracle.com>

On Tue, Apr 08, 2014 at 11:26:56AM -0400, Sasha Levin wrote:
> Hi all,
> 
> (all the below happened inside mm/ code, so while I don't suspect
> it's a mm/ issue you folks got cc'ed anyways!)
> 
> While fuzzing with trinity inside a KVM tools guest running the latest -next
> kernel, I've stumbled on the following:
> 
> [ 4071.166362] BUG: spinlock lockup suspected on CPU#19, trinity-c19/17092

That's a heuristic in the spinlock code; triggering it with big machines
(19 cpus is far bigger than anything at the time that code was written)
and virt (yay for lock owner preemption; another thing we didn't have
back when) is trivial.

I'd not worry too much about this.

So DEBUG_SPINLOCKS turns spin_lock() into something like:

  for (i = 0; i < loops; i++)
  	if (spin_trylock())
		return;

  /* complain */

And you simply ran out of loops.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2014-04-08 16:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-08 15:26 Sasha Levin
2014-04-08 16:10 ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140408161023.GP10526@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@kernel.org \
    --cc=sasha.levin@oracle.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox