From: Andrew Morton <akpm@linux-foundation.org>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Jan Kara <jack@suse.cz>,
Linux Memory Management List <linux-mm@kvack.org>,
kbuild-all@01.org
Subject: Re: [next:master 15/486] fs/notify/fanotify/fanotify_user.c:214:23: error: 'struct fsnotify_event' has no member named 'fae'
Date: Mon, 31 Mar 2014 13:09:31 -0700 [thread overview]
Message-ID: <20140331130931.96219b669e3333da9af6329b@linux-foundation.org> (raw)
In-Reply-To: <53384b3c.gyaYGJJFj2CNi4A/%fengguang.wu@intel.com>
On Mon, 31 Mar 2014 00:50:04 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 201544be8c37dffbf069bb5fc9edb5674f8c1754
> commit: a35f174ec04eaf07a52bb0603ecbb332450d6b4e [15/486] fanotify: use fanotify event structure for permission response processing
> config: x86_64-randconfig-c0-0331 (attached as .config)
>
> Note: the next/master HEAD 201544be8c37dffbf069bb5fc9edb5674f8c1754 builds fine.
> It only hurts bisectibility.
>
> All error/warnings:
>
> fs/notify/fanotify/fanotify_user.c: In function 'copy_event_to_user':
> >> fs/notify/fanotify/fanotify_user.c:214:23: error: 'struct fsnotify_event' has no member named 'fae'
> list_add_tail(&event->fae.fse.list,
> ^
>
> vim +214 fs/notify/fanotify/fanotify_user.c
>
> 208 goto out_close_fd;
> 209
> 210 #ifdef CONFIG_FANOTIFY_ACCESS_PERMISSIONS
> 211 if (event->mask & FAN_ALL_PERM_EVENTS) {
> 212 FANOTIFY_PE(event)->fd = fd;
> 213 mutex_lock(&group->fanotify_data.access_mutex);
> > 214 list_add_tail(&event->fae.fse.list,
> 215 &group->fanotify_data.access_list);
> 216 mutex_unlock(&group->fanotify_data.access_mutex);
> 217 }
This, I suppose.
--- a/fs/notify/fanotify/fanotify_user.c~fanotify-use-fanotify-event-structure-for-permission-response-processing-fix
+++ a/fs/notify/fanotify/fanotify_user.c
@@ -209,9 +209,12 @@ static ssize_t copy_event_to_user(struct
#ifdef CONFIG_FANOTIFY_ACCESS_PERMISSIONS
if (event->mask & FAN_ALL_PERM_EVENTS) {
- FANOTIFY_PE(event)->fd = fd;
+ struct fanotify_perm_event_info *pevent;
+
+ pevent = FANOTIFY_PE(event);
+ pevent->fd = fd;
mutex_lock(&group->fanotify_data.access_mutex);
- list_add_tail(&event->fae.fse.list,
+ list_add_tail(&pevent->fae.fse.list,
&group->fanotify_data.access_list);
mutex_unlock(&group->fanotify_data.access_mutex);
}
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-03-31 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-30 16:50 kbuild test robot
2014-03-31 20:09 ` Andrew Morton [this message]
2014-03-31 21:11 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331130931.96219b669e3333da9af6329b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox