From: Andrew Morton <akpm@linux-foundation.org>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: fengguang.wu@intel.com, linux-mm@kvack.org, kbuild-all@01.org
Subject: Re: [next:master 114/486] fs/proc/task_mmu.c:1120:31: error: 'pagemap_hugetlb' undeclared
Date: Mon, 31 Mar 2014 12:37:40 -0700 [thread overview]
Message-ID: <20140331123740.1007bf1b67ad635495426cce@linux-foundation.org> (raw)
In-Reply-To: <53397020.435fe00a.5cb4.32f9SMTPIN_ADDED_BROKEN@mx.google.com>
On Mon, 31 Mar 2014 09:39:37 -0400 Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
> On Mon, Mar 31, 2014 at 05:08:49PM +0800, kbuild test robot wrote:
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: 8a896813a328f23aeee5f56d3139361534796636
> > commit: 64aa967f459ba0bb91ea8b127c9bd586db1beabc [114/486] pagemap: redefine callback functions for page table walker
> > config: x86_64-randconfig-br2-03311043 (attached as .config)
> >
> > Note: the next/master HEAD 8a896813a328f23aeee5f56d3139361534796636 builds fine.
> > It only hurts bisectibility.
> >
> > All error/warnings:
> >
> > fs/proc/task_mmu.c: In function 'pagemap_read':
> > >> fs/proc/task_mmu.c:1120:31: error: 'pagemap_hugetlb' undeclared (first use in this function)
> > pagemap_walk.hugetlb_entry = pagemap_hugetlb;
> > ^
> > fs/proc/task_mmu.c:1120:31: note: each undeclared identifier is reported only once for each function it appears in
> > fs/proc/task_mmu.c: At top level:
> > fs/proc/task_mmu.c:1025:12: warning: 'pagemap_hugetlb_range' defined but not used [-Wunused-function]
> > static int pagemap_hugetlb_range(pte_t *pte, unsigned long hmask,
> > ^
>
> pagemap_hugetlb_range() should be renamed to pagemap_hugetlb() at 64aa967f459b
> ("pagemap: redefine callback functions for page table walker"), while it is
> currently done by dc86a8715d79 ("pagewalk: remove argument hmask from
> hugetlb_entry()") afterward like below:
>
> @@ -1022,8 +1022,7 @@ static void huge_pte_to_pagemap_entry(pagemap_entry_t *pme, struct pagemapread *
> }
>
> /* This function walks within one hugetlb entry in the single call */
> -static int pagemap_hugetlb_range(pte_t *pte, unsigned long hmask,
> - unsigned long addr, unsigned long end,
> +static int pagemap_hugetlb(pte_t *pte, unsigned long addr, unsigned long end,
> struct mm_walk *walk)
> {
> struct pagemapread *pm = walk->private;
>
> Obviously, dc86a8715d79 should only remove hmask.
> Sorry for my poor patch separation.
It gets messy. I tried this
pagemap-redefine-callback-functions-for-page-table-walker-fix.patch:
--- a/fs/proc/task_mmu.c~pagemap-redefine-callback-functions-for-page-table-walker-fix
+++ a/fs/proc/task_mmu.c
@@ -1022,15 +1022,15 @@ static void huge_pte_to_pagemap_entry(pa
}
/* This function walks within one hugetlb entry in the single call */
-static int pagemap_hugetlb_range(pte_t *pte, unsigned long hmask,
- unsigned long addr, unsigned long end,
- struct mm_walk *walk)
+static int pagemap_hugetlb(pte_t *pte, unsigned long addr, unsigned long end,
+ struct mm_walk *walk)
{
struct pagemapread *pm = walk->private;
struct vm_area_struct *vma = walk->vma;
int err = 0;
int flags2;
pagemap_entry_t pme;
+ unsigned long hmask;
WARN_ON_ONCE(!vma);
and got
fs/proc/task_mmu.c: In function 'pagemap_read':
fs/proc/task_mmu.c:1120: warning: assignment from incompatible pointer type
from
#ifdef CONFIG_HUGETLB_PAGE
pagemap_walk.hugetlb_entry = pagemap_hugetlb;
#endif
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-03-31 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 9:08 kbuild test robot
2014-03-31 13:39 ` Naoya Horiguchi
[not found] ` <53397020.435fe00a.5cb4.32f9SMTPIN_ADDED_BROKEN@mx.google.com>
2014-03-31 19:37 ` Andrew Morton [this message]
2014-03-31 19:50 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331123740.1007bf1b67ad635495426cce@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox