From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f41.google.com (mail-bk0-f41.google.com [209.85.214.41]) by kanga.kvack.org (Postfix) with ESMTP id D00CB6B0116 for ; Tue, 18 Mar 2014 14:26:39 -0400 (EDT) Received: by mail-bk0-f41.google.com with SMTP id d7so534280bkh.0 for ; Tue, 18 Mar 2014 11:26:38 -0700 (PDT) Received: from zene.cmpxchg.org (zene.cmpxchg.org. [2a01:238:4224:fa00:ca1f:9ef3:caee:a2bd]) by mx.google.com with ESMTPS id b7si8433188bko.235.2014.03.18.11.26.37 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 18 Mar 2014 11:26:38 -0700 (PDT) Date: Tue, 18 Mar 2014 14:26:21 -0400 From: Johannes Weiner Subject: Re: [RFC 3/6] mm: support madvise(MADV_FREE) Message-ID: <20140318182621.GH14688@cmpxchg.org> References: <1394779070-8545-1-git-send-email-minchan@kernel.org> <1394779070-8545-4-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1394779070-8545-4-git-send-email-minchan@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , Rik van Riel , Mel Gorman , Hugh Dickins , Dave Hansen , KOSAKI Motohiro , linux-mm@kvack.org, linux-kernel@vger.kernel.org, John Stultz , Jason Evans On Fri, Mar 14, 2014 at 03:37:47PM +0900, Minchan Kim wrote: > Linux doesn't have an ability to free pages lazy while other OS > already have been supported that named by madvise(MADV_FREE). > > The gain is clear that kernel can evict freed pages rather than > swapping out or OOM if memory pressure happens. > > Without memory pressure, freed pages would be reused by userspace > without another additional overhead(ex, page fault + + page allocation > + page zeroing). > > Firstly, heavy users would be general allocators(ex, jemalloc, > I hope ptmalloc support it) and jemalloc already have supported > the feature for other OS(ex, FreeBSD) > > At the moment, this patch would break build other ARCHs which have > own TLB flush scheme other than that x86 but if there is no objection > in this direction, I will add patches for handling other ARCHs > in next iteration. > > Signed-off-by: Minchan Kim > @@ -284,8 +286,17 @@ static long madvise_dontneed(struct vm_area_struct *vma, > .last_index = ULONG_MAX, > }; > zap_page_range(vma, start, end - start, &details); > + } else if (behavior == MADV_FREE) { > + struct zap_details details = { > + .lazy_free = 1, > + }; > + > + if (vma->vm_file) > + return -EINVAL; > + zap_page_range(vma, start, end - start, &details); Wouldn't a custom page table walker to clear dirty bits and move pages be better? It's awkward to hook this into the freeing code and then special case the pages and not actually free them. > @@ -817,6 +817,25 @@ static unsigned long shrink_page_list(struct list_head *page_list, > > sc->nr_scanned++; > > + if (PageLazyFree(page)) { > + switch (try_to_unmap(page, ttu_flags)) { I don't get why we need a page flag for this. page_check_references() could use the rmap walk to also check if any pte/pmd is dirty. If so, you have to swap the page. If all are clean, it can be discarded. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org