From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com [209.85.214.49]) by kanga.kvack.org (Postfix) with ESMTP id C40016B00B1 for ; Wed, 12 Mar 2014 10:53:05 -0400 (EDT) Received: by mail-bk0-f49.google.com with SMTP id my13so1365979bkb.8 for ; Wed, 12 Mar 2014 07:53:05 -0700 (PDT) Received: from zene.cmpxchg.org (zene.cmpxchg.org. [2a01:238:4224:fa00:ca1f:9ef3:caee:a2bd]) by mx.google.com with ESMTPS id qj10si10582376bkb.232.2014.03.12.07.53.03 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 12 Mar 2014 07:53:04 -0700 (PDT) Date: Wed, 12 Mar 2014 10:53:00 -0400 From: Johannes Weiner Subject: Re: [patch 3/8] mm: memcg: inline mem_cgroup_charge_common() Message-ID: <20140312145300.GC14688@cmpxchg.org> References: <1394587714-6966-1-git-send-email-hannes@cmpxchg.org> <1394587714-6966-4-git-send-email-hannes@cmpxchg.org> <20140312125213.GB11831@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140312125213.GB11831@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Mar 12, 2014 at 01:52:13PM +0100, Michal Hocko wrote: > On Tue 11-03-14 21:28:29, Johannes Weiner wrote: > [...] > > @@ -3919,20 +3919,21 @@ out: > > return ret; > > } > > > > -/* > > - * Charge the memory controller for page usage. > > - * Return > > - * 0 if the charge was successful > > - * < 0 if the cgroup is over its limit > > - */ > > -static int mem_cgroup_charge_common(struct page *page, struct mm_struct *mm, > > - gfp_t gfp_mask, enum charge_type ctype) > > +int mem_cgroup_newpage_charge(struct page *page, > > + struct mm_struct *mm, gfp_t gfp_mask) > > s/mem_cgroup_newpage_charge/mem_cgroup_anon_charge/ ? > > Would be a better name? The patch would be bigger but the name more > apparent... I wouldn't be opposed to fixing those names at all, but I think that is out of the scope of this patch. Want to send one? mem_cgroup_charge_anon() would be a good name, but then we should also rename mem_cgroup_cache_charge() to mem_cgroup_charge_file() to match. Or charge_private() vs. charge_shared()... > Other than that I am good with this. Without (preferably) or without > rename: > Acked-by: Michal Hocko Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org