From: Michal Hocko <mhocko@suse.cz>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 3/8] mm: memcg: inline mem_cgroup_charge_common()
Date: Wed, 12 Mar 2014 13:52:13 +0100 [thread overview]
Message-ID: <20140312125213.GB11831@dhcp22.suse.cz> (raw)
In-Reply-To: <1394587714-6966-4-git-send-email-hannes@cmpxchg.org>
On Tue 11-03-14 21:28:29, Johannes Weiner wrote:
[...]
> @@ -3919,20 +3919,21 @@ out:
> return ret;
> }
>
> -/*
> - * Charge the memory controller for page usage.
> - * Return
> - * 0 if the charge was successful
> - * < 0 if the cgroup is over its limit
> - */
> -static int mem_cgroup_charge_common(struct page *page, struct mm_struct *mm,
> - gfp_t gfp_mask, enum charge_type ctype)
> +int mem_cgroup_newpage_charge(struct page *page,
> + struct mm_struct *mm, gfp_t gfp_mask)
s/mem_cgroup_newpage_charge/mem_cgroup_anon_charge/ ?
Would be a better name? The patch would be bigger but the name more
apparent...
Other than that I am good with this. Without (preferably) or without
rename:
Acked-by: Michal Hocko <mhocko@suse.cz>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-03-12 12:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 1:28 [patch 0/8] memcg: charge path cleanups Johannes Weiner
2014-03-12 1:28 ` [patch 1/8] mm: memcg: remove unnecessary preemption disabling Johannes Weiner
2014-03-12 1:28 ` [patch 2/8] mm: memcg: remove mem_cgroup_move_account_page_stat() Johannes Weiner
2014-03-12 1:28 ` [patch 3/8] mm: memcg: inline mem_cgroup_charge_common() Johannes Weiner
2014-03-12 12:52 ` Michal Hocko [this message]
2014-03-12 14:53 ` Johannes Weiner
2014-03-12 15:19 ` Michal Hocko
2014-03-12 15:20 ` [PATCH] memcg: rename high level charging functions Michal Hocko
2014-03-12 1:28 ` [patch 4/8] mm: memcg: push !mm handling out to page cache charge function Johannes Weiner
2014-03-12 13:11 ` Michal Hocko
2014-03-12 14:56 ` Johannes Weiner
2014-03-12 15:01 ` Michal Hocko
2014-03-12 1:28 ` [patch 5/8] memcg: remove unnecessary !mm check from try_get_mem_cgroup_from_mm() Johannes Weiner
2014-03-12 1:28 ` [patch 6/8] memcg: get_mem_cgroup_from_mm() Johannes Weiner
2014-03-12 1:28 ` [patch 7/8] memcg: do not replicate get_mem_cgroup_from_mm in __mem_cgroup_try_charge Johannes Weiner
2014-03-12 1:28 ` [patch 8/8] memcg: sanitize __mem_cgroup_try_charge() call protocol Johannes Weiner
2014-03-12 14:01 ` Michal Hocko
2014-03-12 14:05 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312125213.GB11831@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox