From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) by kanga.kvack.org (Postfix) with ESMTP id 75D7E6B0038 for ; Tue, 11 Mar 2014 15:31:36 -0400 (EDT) Received: by mail-pd0-f179.google.com with SMTP id w10so9017108pde.10 for ; Tue, 11 Mar 2014 12:31:36 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTP id yo5si21106698pab.121.2014.03.11.12.31.35 for ; Tue, 11 Mar 2014 12:31:35 -0700 (PDT) Date: Tue, 11 Mar 2014 12:31:33 -0700 From: Andrew Morton Subject: Re: mmotm 2014-03-10-15-35 uploaded (virtio_balloon) Message-Id: <20140311123133.f40adf3154452e82aecb61ca@linux-foundation.org> In-Reply-To: <20140311192046.GA2686@leaf> References: <20140310223701.0969C31C2AA@corp2gmr1-1.hot.corp.google.com> <531F43F2.1030504@infradead.org> <20140311110338.333e1ee691cadb0f20dbb083@linux-foundation.org> <20140311192046.GA2686@leaf> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Josh Triplett Cc: Randy Dunlap , mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org, Rusty Russell , virtio-dev@lists.oasis-open.org, "Michael S. Tsirkin" On Tue, 11 Mar 2014 12:20:46 -0700 Josh Triplett wrote: > > > ERROR: "balloon_devinfo_alloc" [drivers/virtio/virtio_balloon.ko] undefined! > > > ERROR: "balloon_page_enqueue" [drivers/virtio/virtio_balloon.ko] undefined! > > > ERROR: "balloon_page_dequeue" [drivers/virtio/virtio_balloon.ko] undefined! > > > > > > when loadable module > > > > > > or > > > > > > virtio_balloon.c:(.text+0x1fa26): undefined reference to `balloon_page_enqueue' > > > virtio_balloon.c:(.text+0x1fb87): undefined reference to `balloon_page_dequeue' > > > virtio_balloon.c:(.text+0x1fdf1): undefined reference to `balloon_devinfo_alloc' > > > > > > when builtin. > > > > OK, thanks, I'll drop > > http://ozlabs.org/~akpm/mmots/broken-out/mm-disable-mm-balloon_compactionc-completely-when-config_balloon_compaction.patch > > Sorry about that; I missed that case in my testing. It always seems > strange that the dependency goes that way around. > > With virtio-balloon being the one and only user of this API, would it be > reasonable to just only compile in balloon_compaction.o when > CONFIG_VIRTIO_BALLOON? Better to make VIRTIO_BALLOON depend on (or select) BALLOON_COMPACTION. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org