From: Andrew Morton <akpm@linux-foundation.org>
To: Davidlohr Bueso <davidlohr@hp.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Johannes Weiner <hannes@cmpxchg.org>,
kbuild-all@01.org
Subject: Re: [mmotm:master 188/471] include/linux/swap.h:33:16: error: dereferencing pointer to incomplete type
Date: Wed, 5 Mar 2014 19:54:43 -0800 [thread overview]
Message-ID: <20140305195443.783f14ee.akpm@linux-foundation.org> (raw)
In-Reply-To: <1394077577.29724.19.camel@buesod1.americas.hpqcorp.net>
On Wed, 05 Mar 2014 19:46:17 -0800 Davidlohr Bueso <davidlohr@hp.com> wrote:
> On Thu, 2014-03-06 at 11:24 +0800, kbuild test robot wrote:
> > tree: git://git.cmpxchg.org/linux-mmotm.git master
> > head: f6bf2766c2091cbf8ffcc2c5009875dbdb678282
> > commit: 88a76abced8c721ac726ea6a273ed0389b1c5ff4 [188/471] mm: per-thread vma caching
> > config: make ARCH=sparc defconfig
> >
> > All error/warnings:
> >
> > In file included from arch/sparc/include/asm/pgtable_32.h:17:0,
> > from arch/sparc/include/asm/pgtable.h:6,
> > from include/linux/mm.h:51,
> > from include/linux/vmacache.h:4,
> > from include/linux/sched.h:26,
> > from arch/sparc/kernel/asm-offsets.c:13:
> > include/linux/swap.h: In function 'current_is_kswapd':
> > >> include/linux/swap.h:33:16: error: dereferencing pointer to incomplete type
> > >> include/linux/swap.h:33:26: error: 'PF_KSWAPD' undeclared (first use in this function)
> > include/linux/swap.h:33:26: note: each undeclared identifier is reported only once for each function it appears in
> > make[2]: *** [arch/sparc/kernel/asm-offsets.s] Error 1
> > make[2]: Target `__build' not remade because of errors.
> > make[1]: *** [prepare0] Error 2
> > make[1]: Target `prepare' not remade because of errors.
> > make: *** [sub-make] Error 2
> >
> > vim +33 include/linux/swap.h
>
> I knew something like this was gonna happen with the whole header file
> thing. Andrew, would you prefer getting rid of vmacache.h and just
> sticking the contents in mm.h? I was hoping not to do that, but if it
> causes a lot of pain then the hell with it.
My usual approach to this sort of thing is to go finer-grained, so it
cannot happen again. ie: move all the PF_foo definitions into their
own little header. I assume this will fix it.
I'll take care of doing that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-03-06 3:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 3:24 kbuild test robot
2014-03-06 3:46 ` Davidlohr Bueso
2014-03-06 3:54 ` Andrew Morton [this message]
2014-03-06 3:59 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305195443.783f14ee.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davidlohr@hp.com \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox